Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging 2.25.0 ck8s4 #389

Merged
merged 5 commits into from
Sep 4, 2024
Merged

Staging 2.25.0 ck8s4 #389

merged 5 commits into from
Sep 4, 2024

Conversation

Ajarmar
Copy link
Contributor

@Ajarmar Ajarmar commented Sep 4, 2024

Warning

This is a public repository, ensure not to disclose:

  • personal data beyond what is necessary for interacting with this pull request, nor
  • business confidential information, such as customer names.

What kind of PR is this?

Required: Mark one of the following that is applicable:

  • kind/feature
  • kind/improvement
  • kind/deprecation
  • kind/documentation
  • kind/clean-up
  • kind/bug
  • kind/other

Optional: Mark one or more of the following that are applicable:

Important

Breaking changes should be marked kind/admin-change or kind/dev-change depending on type
Critical security fixes should be marked with kind/security

  • kind/admin-change
  • kind/dev-change
  • kind/security
  • kind/adr

What does this PR do / why do we need this PR?

Patch release v2.25.0-ck8s4.

Information to reviewers

Some notes regarding the changelog:

  • We had several commits in the kubespray submodule that are represented by just one commit in the compliantkubernetes-kubespray repo, so I added the individual commits in the submodule into the changelog instead. Let me know what you think.
  • Please have a look at how the "Known issues" in the changelog are formatted and let me know what you think about that as well.

Checklist

  • Proper commit message prefix on all commits
  • Change checks:
    • The change is transparent
    • The change is disruptive
    • The change requires no migration steps
    • The change requires migration steps
  • Metrics checks:
    • The metrics are still exposed and present in Grafana after the change
    • The metrics names didn't change (Grafana dashboards and Prometheus alerts are not affected)
    • The metrics names did change (Grafana dashboards and Prometheus alerts were fixed)
  • Logs checks:
    • The logs do not show any errors after the change
  • Pod Security Policy checks:
    • Any changed pod is covered by Pod Security Admission
    • Any changed pod is covered by Gatekeeper Pod Security Policies
    • The change does not cause any pods to be blocked by Pod Security Admission or Policies
  • Network Policy checks:
    • Any changed pod is covered by Network Policies
    • The change does not cause any dropped packets in the NetworkPolicy Dashboard
  • Audit checks:
    • The change does not cause any unnecessary Kubernetes audit events
    • The change requires changes to Kubernetes audit policy
  • Falco checks:
    • The change does not cause any alerts to be generated by Falco
  • Bug checks:
    • The bug fix is covered by regression tests

@Ajarmar Ajarmar marked this pull request as ready for review September 4, 2024 12:19
@@ -9,6 +9,10 @@ Released 2024-07-04
> [!NOTE]
> **Application Developer Notice(s)**
> - The default `topologySpreadConstraints` for kube scheduler changed. You may want to review existing pod scheduling constraints that could now be redundant. <!-- same as admin notice but may apply to both? -->
<!-- -->
> [!IMPORTANT]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this maybe be a warning or caution instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Based on the descriptions found here, I think "Warning" may be most accurate.

@Ajarmar Ajarmar force-pushed the staging-2.25.0-ck8s4 branch from eaed3f0 to 4dec9e0 Compare September 4, 2024 12:51
Copy link
Contributor

@aarnq aarnq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines 72 to 77
- [kubernetes-sigs/kubespray#11476](https://github.com/kubernetes-sigs/kubespray/pull/11476) - [calico] Update calico to v3.27.4 to fix high cpu issues
- [elastisys/kubespray#18](https://github.com/elastisys/kubespray/pull/18) - Multiple tunnels per connection in UpCloud [@aarnq](https://github.com/aarnq)

### Other(s)

- [#386](https://github.com/elastisys/compliantkubernetes-kubespray/pull/386) - documentation: docs: Update migration guide with missing export command for variable [@lucianvlad](https://github.com/lucianvlad)
Copy link
Contributor

@OlleLarsson OlleLarsson Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want something like this?

Suggested change
- [kubernetes-sigs/kubespray#11476](https://github.com/kubernetes-sigs/kubespray/pull/11476) - [calico] Update calico to v3.27.4 to fix high cpu issues
- [elastisys/kubespray#18](https://github.com/elastisys/kubespray/pull/18) - Multiple tunnels per connection in UpCloud [@aarnq](https://github.com/aarnq)
### Other(s)
- [#386](https://github.com/elastisys/compliantkubernetes-kubespray/pull/386) - documentation: docs: Update migration guide with missing export command for variable [@lucianvlad](https://github.com/lucianvlad)
- [kubernetes-sigs/kubespray#11476](https://github.com/kubernetes-sigs/kubespray/pull/11476) - Update calico to v3.27.4 to fix high cpu issues
- [elastisys/kubespray#18](https://github.com/elastisys/kubespray/pull/18) - Multiple tunnels per connection in UpCloud [@aarnq](https://github.com/aarnq)
### Other(s)
- [#386](https://github.com/elastisys/compliantkubernetes-kubespray/pull/386) - Update migration guide with missing export command for variable [@lucianvlad](https://github.com/lucianvlad)

@Ajarmar Ajarmar force-pushed the staging-2.25.0-ck8s4 branch from 4dec9e0 to c9b06c5 Compare September 4, 2024 14:06
@Ajarmar Ajarmar merged commit b4715b8 into release-2.25.0 Sep 4, 2024
2 checks passed
@Ajarmar Ajarmar deleted the staging-2.25.0-ck8s4 branch September 4, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants