Qa 2.23.0 #326
Merged
Qa 2.23.0 #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlleLarsson
approved these changes
Oct 13, 2023
Xartos
reviewed
Oct 16, 2023
Xartos
approved these changes
Oct 16, 2023
davidumea
reviewed
Oct 16, 2023
Pavan-Gunda
force-pushed
the
QA-2.23.0
branch
from
689163e to
609248a
Compare
OlleLarsson
approved these changes
Oct 16, 2023
aarnq
reviewed
Oct 16, 2023
Comment on lines
+27
to
+32
| 1. Set `ck8sKubesprayVersion` to `any` in `sc-config/group_vars/all/ck8s-kubespray-general.yaml` and `wc-config/group_vars/all/ck8s-kubespray-general.yaml` | ||
|
|
||
| ```bash | ||
| yq4 -i '.ck8sKubesprayVersion = "any"' ${CK8S_CONFIG_PATH}/sc-config/group_vars/all/ck8s-kubespray-general.yaml | ||
| yq4 -i '.ck8sKubesprayVersion = "any"' ${CK8S_CONFIG_PATH}/wc-config/group_vars/all/ck8s-kubespray-general.yaml | ||
| ``` |
There was a problem hiding this comment.
Is there a bug or something in the upgrade prepare scripts, cause shouldn't this be properly managed by it?
There was a problem hiding this comment.
There seems to be a bug in the upgrade prepare scripts, they are not working until we set the version to any.
There was a problem hiding this comment.
OK, we should definitely fix that for the next release.
aarnq
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of PR is this?
Required: Mark one of the following that is applicable:
Optional: Mark one or more of the following that are applicable:
Important
Critical security fixes should be marked with
kind/securityBreaking changes should be marked
kind/admin-changeorkind/dev-changedepending on typeWhat does this PR do / why do we need this PR?
...
Additional information to reviewers
Screenshots
Checklist
NetworkPolicy Dashboard