Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Licensing and Chart Setup #21

Merged
merged 21 commits into from
Jun 27, 2024
Merged

Improve Licensing and Chart Setup #21

merged 21 commits into from
Jun 27, 2024

Conversation

kgrubb
Copy link
Contributor

@kgrubb kgrubb commented Jun 20, 2024 •
edited
Loading

Description

  • add opensearch output options.
  • allow more robust service creation.
  • add account id to netobserv secret.
  • allow configurable update strategy type.
  • Add documentation on licensing and configuration options.

@kgrubb kgrubb self-assigned this Jun 20, 2024
maksym-iv-elf
maksym-iv-elf requested changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@maksym-iv-elf maksym-iv-elf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added few notes

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
charts/netobserv/templates/deployment.yaml Outdated Show resolved Hide resolved
charts/netobserv/templates/deployment.yaml Outdated Show resolved Hide resolved
charts/netobserv/templates/deployment.yaml Outdated Show resolved Hide resolved
charts/netobserv/values.yaml Outdated Show resolved Hide resolved
charts/netobserv/values.yaml Show resolved Hide resolved
charts/netobserv/values.yaml Outdated Show resolved Hide resolved
charts/netobserv/values.yaml Outdated Show resolved Hide resolved
charts/netobserv/values.yaml Outdated Show resolved Hide resolved
kgrubb and others added 10 commits June 21, 2024 11:09
@kgrubb @maksym-iv-elf
Update README.md
7585eaf 
Co-authored-by: Mack (Maksym Iv) <[email protected]>
@kgrubb @maksym-iv-elf
Update charts/netobserv/templates/deployment.yaml
17c93e6 
Co-authored-by: Mack (Maksym Iv) <[email protected]>
@kgrubb @maksym-iv-elf
Update charts/netobserv/values.yaml
6007989 
Co-authored-by: Mack (Maksym Iv) <[email protected]>
@kgrubb
make strategy more robust instead of just selecting strategy type. re…
c51de3f 
…move nodeSelector in favor of just using affinity. move container ports up a level, since container is implied.
@kgrubb
fix invalid yaml config for strategy
2d47cce
@kgrubb @maksym-iv-elf
Update charts/netobserv/templates/deployment.yaml
a5704c1 
Co-authored-by: Mack (Maksym Iv) <[email protected]>
@kgrubb @maksym-iv-elf
Update charts/netobserv/templates/service.yaml
2b5ebe7 
Co-authored-by: Mack (Maksym Iv) <[email protected]>
@kgrubb
move accountid outside of secrets, since it is not a secret. fix serv…
e2ba0c8 
…ice annotations setup. add documentation around license key security
@kgrubb
Merge branch 'prepare-for-release' of github.com:elastiflow/helm-char…
d5ec49f 
…t-netobserv into prepare-for-release
@kgrubb
bump memory to a higher default. update docs in readme to reference e…
9efcdf6 
…nv and kubernetes values configs
@maksym-iv-elf
Copy link
Contributor

Additional comments

  • We may also want to add startupProbe, all probes should be enabled by default, K8s needs to check health somehow
  • Adding extraVolumes/VolumeMounts like here may make sense to allow arbitrary volume mounts

@kgrubb kgrubb merged commit 7d06bdb into main Jun 27, 2024
2 checks passed
@kgrubb kgrubb deleted the prepare-for-release branch June 27, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maksym-iv-elf maksym-iv-elf maksym-iv-elf approved these changes

@scmartin69 scmartin69 Awaiting requested review from scmartin69

Assignees

@kgrubb kgrubb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kgrubb @maksym-iv-elf