Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-1780: Include maxmind account id #14

Merged
merged 12 commits into from
Apr 25, 2024
Merged

Conversation

kgrubb
Copy link
Contributor

@kgrubb kgrubb commented Apr 18, 2024

Description

MaxMind requires an account id in addition to the license key for downloading geoip and asn data. This adds the necessary values

…nloading geoip and asn data. This adds the necessary values
@kgrubb kgrubb self-assigned this Apr 18, 2024
maksym-iv-elf
maksym-iv-elf previously approved these changes Apr 18, 2024
@kgrubb kgrubb requested a review from maksym-iv-elf April 18, 2024 15:11
@kgrubb kgrubb requested a review from maksym-iv-elf April 23, 2024 14:49
maksym-iv-elf
maksym-iv-elf previously approved these changes Apr 23, 2024
… value in the values file (and still allow for override).
@kgrubb kgrubb requested a review from maksym-iv-elf April 24, 2024 14:23
Copy link
Contributor

@maksym-iv-elf maksym-iv-elf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added few comments

@kgrubb kgrubb merged commit b7ba3da into main Apr 25, 2024
2 checks passed
@kgrubb kgrubb deleted the ENG-1780-include-account-id branch April 25, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants