Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Maxmind GeoLite2 geolocation Data #13

Merged
merged 5 commits into from
Apr 17, 2024
Merged

Enable Maxmind GeoLite2 geolocation Data #13

merged 5 commits into from
Apr 17, 2024

Conversation

kgrubb
Copy link
Contributor

@kgrubb kgrubb commented Apr 16, 2024

Description

This adds an optional volume mount and initContainer for downloading and mounting MaxMind GeoLite2 geo data. If the EF_PROCESSOR_ENRICH_IPADDR_MAXMIND_ASN_ENABLE and EF_PROCESSOR_ENRICH_IPADDR_MAXMIND_GEOIP_ENABLE environment variables are set to true, a user can enable MaxMind and provide a MaxMind license key like so in their values.yaml:

maxmind:
  enabled: true
  licenseKey: "my_license_key"

The License Key can also be provided via a set command in a helm install:

--set=maxmind.licenseKey=my_license_key

@kgrubb kgrubb self-assigned this Apr 16, 2024
kgrubb added 2 commits April 16, 2024 15:38
@kgrubb
split initcontainers for asn and city mmdb fetching
2b946b6
@kgrubb
fix an issue where an empty volumes section in the values file would …
9a186fd 
…prevent the geoip and asn volume mount from being added to volumes and volume mounts.
@kgrubb kgrubb requested a review from maksym-iv-elf April 16, 2024 21:03
maksym-iv-elf
maksym-iv-elf requested changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@maksym-iv-elf maksym-iv-elf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, few notes

charts/netobserv/templates/deployment.yaml Outdated Show resolved Hide resolved
charts/netobserv/templates/deployment.yaml Outdated Show resolved Hide resolved
charts/netobserv/templates/deployment.yaml Outdated Show resolved Hide resolved
charts/netobserv/values.yaml Outdated Show resolved Hide resolved
@kgrubb kgrubb requested a review from maksym-iv-elf April 17, 2024 16:31
@kgrubb
remove arbitrary volume nad volume mounts, since there aren't really …
4ec6861 
…any use cases to add a volume or volume mount to the deployment
@kgrubb kgrubb merged commit 0e6cc15 into main Apr 17, 2024
2 checks passed
@kgrubb kgrubb deleted the ENG-1780-add-maxmind-geoip-volume-mounts branch April 17, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maksym-iv-elf maksym-iv-elf maksym-iv-elf approved these changes

@svencowart svencowart Awaiting requested review from svencowart

Assignees

@kgrubb kgrubb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kgrubb @maksym-iv-elf