Support saved searches in inliner script #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewdaemon
commented
Nov 29, 2023
|
@shmsr this seems to be working. Do you want to validate before we merge this? |
Okay. I will check this and provide you with an update soon. |
kertal
reviewed
Dec 1, 2023
kertal
reviewed
Dec 5, 2023
Looks good. I tried this script with redis package only. Thanks Drew! |
shmsr
approved these changes
Dec 7, 2023
Co-authored-by: subham sarkar <[email protected]>
Co-authored-by: subham sarkar <[email protected]>
Co-authored-by: subham sarkar <[email protected]>
Co-authored-by: subham sarkar <[email protected]>
davismcphee
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Code-only review of the saved search attributes changes @drewdaemon and I synced about earlier -- LGTM, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2
Consider this effort a follow-on to elastic/package-spec#633.
That issue was to express our preference to have saved searches be by-value in integrations.
This PR is to make it easy for package developers to inline all the saved searches in a particular integration.