Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add Kibana security roles #435

Merged
merged 13 commits into from
Oct 24, 2023
Merged

[Feature] Add Kibana security roles #435

merged 13 commits into from
Oct 24, 2023

Conversation

nimdeveloper
Copy link
Contributor

Closes #406

@cla-checker-service
Copy link

cla-checker-service bot commented Sep 27, 2023 •
edited
Loading

💚 CLA has been signed

tobio
tobio reviewed Oct 3, 2023
View reviewed changes
Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, added some comments inline.

Can we also add an entry to the changelog for this PR.

docs/data-sources/kibana_security_role.md Outdated Show resolved Hide resolved
internal/kibana/role.go Outdated Show resolved Hide resolved
internal/kibana/role.go Show resolved Hide resolved
internal/kibana/role.go Show resolved Hide resolved
internal/kibana/role.go Outdated Show resolved Hide resolved
internal/kibana/role.go Outdated Show resolved Hide resolved
internal/kibana/role.go Outdated Show resolved Hide resolved
examples/resources/elasticstack_kibana_security_role/import.sh Outdated Show resolved Hide resolved
internal/kibana/role.go Outdated Show resolved Hide resolved
internal/kibana/role_data_source.go Outdated Show resolved Hide resolved
@nimdeveloper
Copy link
Contributor Author

Thanks for this, added some comments inline.

Can we also add an entry to the changelog for this PR.

Thanks for the reply, I updated the reviews mentioned.

tobio
tobio reviewed Oct 15, 2023
View reviewed changes
Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some minor naming nits.

CHANGELOG.md Outdated Show resolved Hide resolved
internal/kibana/role.go Outdated Show resolved Hide resolved
internal/kibana/role.go Outdated Show resolved Hide resolved
internal/kibana/role.go Outdated Show resolved Hide resolved
internal/kibana/role.go Outdated Show resolved Hide resolved
internal/kibana/role.go Outdated Show resolved Hide resolved
internal/kibana/role.go Outdated Show resolved Hide resolved
internal/kibana/role.go Outdated Show resolved Hide resolved
internal/kibana/role.go Outdated Show resolved Hide resolved
internal/kibana/role.go Outdated Show resolved Hide resolved
tobio
tobio approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, this is awesome thanks!

@nimdeveloper nimdeveloper requested a review from tobio October 17, 2023 08:23
@tobio tobio enabled auto-merge (squash) October 24, 2023 03:45
@tobio tobio disabled auto-merge October 24, 2023 03:45
@tobio tobio merged commit 9481804 into elastic:main Oct 24, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobio tobio Awaiting requested review from tobio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Support for Kibana permissions in security role
2 participants
@nimdeveloper @tobio