Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support configurable chunk size #944

Conversation

dominiqueclarke
Copy link
Contributor

Adds an environment variable to configure chunk size when pushing monitors to Kibana.

Testing

  1. Create a test project
  2. Check out this PR. Run npm install then npm run build.
  3. Run npm link
  4. Check out the directory for the test project
  5. run npm link @elastic/synthetics
  6. Run CHUNK_SIZE=1 SYNTHETICS_API_KEY=MXhmQURwRUI1UGtRakt5TW5zWk46VWtFTWJrbE9RMjZTdFBrRVpFd190Zw== npm run push
  7. Watch as only 1 monitor is pushed at a time

@dominiqueclarke dominiqueclarke changed the title Support configurable chunk size feat: support configurable chunk size Aug 1, 2024
Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jasonrhodes jasonrhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on behalf of our team but because Vignesh already reviewed and approved. We will fix this repo so his approval is enough (but keep our team as possible reviewers too, even if we have to create a new GH team to achieve this)...

@vigneshshanmugam
Copy link
Member

vigneshshanmugam commented Aug 1, 2024

New changes require approval from someone other than vigneshshanmugam because they were the last pusher.

I think its because I pushed a change.

@vigneshshanmugam
Copy link
Member

@dominiqueclarke If you can squash my commit along with yours and remove mine using rebase, We can get this merged faster.

@jasonrhodes
Copy link
Member

@vigneshshanmugam are you the only one who can approve PRs for merge in this repo?

adjust test

confirm if pushed
@dominiqueclarke dominiqueclarke force-pushed the feat/support-configurable-chunk-size branch from 73d092f to 1169efb Compare August 2, 2024 11:40
@dominiqueclarke dominiqueclarke merged commit b7603d8 into elastic:main Aug 2, 2024
6 checks passed
@dominiqueclarke dominiqueclarke deleted the feat/support-configurable-chunk-size branch August 2, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants