fix: only append 'Elastic/Synthetics' to default UA #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
vigneshshanmugam
changed the title
When we originally implemented elastic#232 it appears we didn't implement the third AC, allowing users to override our custom UA string "Elastic/Synthetics" which is appended. Some users need to fully replace the UA, this allows them to do that. Rather than adding a boolean, this assumes that if you're overriding the UA you want full control, which is more in line with the principle of least surprise.
vigneshshanmugam
force-pushed
the
only-append-ua-default
branch
from
d1ed2e3 to
9fad6f0
Compare
vigneshshanmugam
approved these changes
Jun 3, 2022
|
Post-FF testing LGTM: I set up a project like: // synthetics.config.js
const config = {
playwrightOptions: {
userAgent: "DO NOT SAY ELASTIC",
},
};
module.exports = config;// test.journey.ts
const { journey, step, expect } = require('@elastic/synthetics');
journey(
{ name: 'Test', tags: ['browse'] },
({ page, params }) => {
step('go to my untrusted HTTPS endpoint', async () => {
await page.goto('https://www.whatismybrowser.com/');
await new Promise(r => setTimeout(r, 50000));
});
}
);When running the journey, I got the following output:
|
|
POST FF Testing looks good !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we originally implemented #232 it appears we didn't implement the third AC, allowing users to override our custom UA string "Elastic/Synthetics" which is appended.
Some users need to fully replace the UA, this allows them to do that. Rather than adding a boolean, this assumes that if you're overriding the UA you want full control, which is more in line with the principle of least surprise.
CC @paulb-elastic @drewpost
PS this is currently a draft because there are no tests, I'll add tests if we agree on this approach.