-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add request timing calculation for waterfall #168
feat: add request timing calculation for waterfall #168
Conversation
👀👀👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've run this via the CLI against a few journeys and the values are looking much better 👍 (It'll also be massively beneficial to have these here vs in the UI).
It was still possible for me to see values that ran in to seconds when the journey contained multiple navigations. As an example against one specific asset prior to this PR I was getting a value of around 3 seconds consistently, with the changes here I'm seeing an average of 1 second. So it's much, much better. In Chrome dev tools that asset runs in the ms, so things still seem a little higher in certain scenarios, but I'm not confident enough to say something is actually "wrong".
@Kerry350 Thanks for the review. Yes it would be possible to see high values even in seconds for assets even with this PR when the assert is of type Example gif - https://www.thebmc.co.uk/media/images/Banners/summit%20600x100px.gif Running through our agent - different run not same one
|
--network
flag is enabled. The output is expected to be in the formatAll of the data is in
milliseconds
and any missing data will be denoted with-1