Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add request timing calculation for waterfall #168

Merged
merged 3 commits into from
Dec 10, 2020

Conversation

vigneshshanmugam
Copy link
Member

{
  blocked: 0.8809999562799931,
  queueing: 0.49599993508309126,
  proxy: -1,
  dns: -1,
  ssl: -1,
  connect: -1,
  send: 0.1300000585615635,
  wait: 60.22300000768155,
  receive: 0.9560000617057085,
  total: 62.686000019311905
}

All of the data is in milliseconds and any missing data will be denoted with -1

@Kerry350
Copy link

👀👀👀

@apmmachine
Copy link

apmmachine commented Dec 10, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #168 updated

  • Start Time: 2020-12-10T13:36:39.313+0000

  • Duration: 17 min 46 sec

Test stats 🧪

Test Results
Failed 0
Passed 46
Skipped 0
Total 46

Copy link

@Kerry350 Kerry350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've run this via the CLI against a few journeys and the values are looking much better 👍 (It'll also be massively beneficial to have these here vs in the UI).

It was still possible for me to see values that ran in to seconds when the journey contained multiple navigations. As an example against one specific asset prior to this PR I was getting a value of around 3 seconds consistently, with the changes here I'm seeing an average of 1 second. So it's much, much better. In Chrome dev tools that asset runs in the ms, so things still seem a little higher in certain scenarios, but I'm not confident enough to say something is actually "wrong".

@vigneshshanmugam
Copy link
Member Author

@Kerry350 Thanks for the review. Yes it would be possible to see high values even in seconds for assets even with this PR when the assert is of type .gif, streaming downloads, progressive jpegs. In these cases the first byte arrives faster which means faster wait times (TTFB), but the content download takes a longer time.

Example gif - https://www.thebmc.co.uk/media/images/Banners/summit%20600x100px.gif

Screenshot 2020-12-10 at 20 29 09

Running through our agent - different run not same one

val https://www.thebmc.co.uk/media/images/Banners/summit%20600x100px.gif {
  blocked: 0.5070000188425183,
  queueing: 1.1180000146850944,
  proxy: -1,
  dns: 0.7249999325722456,
  ssl: 606.307000038214,
  connect: 778.0400000046939,
  send: 0.27600000612437725,
  wait: 775.154999922961,
  receive: 1124.0200001047924,
  total: 2680.0800000783056
}

@vigneshshanmugam vigneshshanmugam merged commit 394a6fa into elastic:master Dec 10, 2020
@vigneshshanmugam vigneshshanmugam deleted the add-timing-calc branch December 10, 2020 15:01
Kerry350 added a commit to Kerry350/kibana that referenced this pull request Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Values / calculations for receive / content downloading times seem too high
3 participants