Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disallow auto update of chrome browser #150

Merged

Conversation

vigneshshanmugam
Copy link
Member

@apmmachine
Copy link

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #150 opened

  • Start Time: 2020-11-26T11:01:21.813+0000

  • Duration: 16 min 14 sec

Test stats 🧪

Test Results
Failed 0
Passed 45
Skipped 0
Total 45

Copy link
Contributor

@hmdhk hmdhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vigneshshanmugam, Can we at least allow the patch versions? Is there a precedent for patch versions making an issue?

@vigneshshanmugam
Copy link
Member Author

yeah patch versions also updates the browser https://github.com/microsoft/playwright/releases which would be an issue for us as it would trigger removing the old browser version in favor of new one. So, we need to stick with exact match.

Copy link
Contributor

@hmdhk hmdhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! I think we should separate the update cycle of the browser from the update of playwright (we can do that as part of the packaging ticket).

@@ -39,7 +39,7 @@
"dependencies": {
"commander": "^6.0.0",
"kleur": "^4.1.1",
"playwright-chromium": "^1.6.2",
"playwright-chromium": "=1.6.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just specifying the exact version would pin the version. I wasn't sure about the = syntax since it's not mentioned in the npm docs.

Suggested change
"playwright-chromium": "=1.6.2",
"playwright-chromium": "1.6.2",

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants