-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: disallow auto update of chrome browser #150
chore: disallow auto update of chrome browser #150
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vigneshshanmugam, Can we at least allow the patch versions? Is there a precedent for patch versions making an issue?
yeah patch versions also updates the browser https://github.com/microsoft/playwright/releases which would be an issue for us as it would trigger removing the old browser version in favor of new one. So, we need to stick with exact match. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good! I think we should separate the update cycle of the browser from the update of playwright (we can do that as part of the packaging ticket).
@@ -39,7 +39,7 @@ | |||
"dependencies": { | |||
"commander": "^6.0.0", | |||
"kleur": "^4.1.1", | |||
"playwright-chromium": "^1.6.2", | |||
"playwright-chromium": "=1.6.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just specifying the exact version would pin the version. I wasn't sure about the =
syntax since it's not mentioned in the npm docs.
"playwright-chromium": "=1.6.2", | |
"playwright-chromium": "1.6.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its part of semver https://github.com/npm/node-semver
^
or~
would allow minor/patch versions to be installed on user's machine/test environments if lockfiles are not taken in to account.