Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sync browser version in docker and examples #147

Merged
merged 1 commit into from
Nov 26, 2020

Conversation

vigneshshanmugam
Copy link
Member

Steps to test this flow.

// remove the previous docker image if you want to test in a clean environment
docker rmi heartbeat-synthetics-local
npm run docker 
cd examples/docker
./run-build-local.sh -E output.console={}

@apmmachine
Copy link

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #147 opened]

  • Start Time: 2020-11-24T16:03:08.849+0000

  • Duration: 13 min 15 sec

Test stats 🧪

Test Results
Failed 0
Passed 45
Skipped 0
Total 45

Copy link
Contributor

@paulb-elastic paulb-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've run this locally and it works, I'm getting the JSON output from the synthetic monitors that are running. I had to authorise with the docker registry before this would work.

@vigneshshanmugam
Copy link
Member Author

Will revisit later with better alternatives if we decide to do docker cache cleanup at some point for building new images.

@vigneshshanmugam vigneshshanmugam merged commit d0670a7 into elastic:master Nov 26, 2020
@vigneshshanmugam vigneshshanmugam deleted the use-same-revision branch November 26, 2020 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run Playwright post-install script to fix chrome binary sometimes unavailable
3 participants