Upgrade EUI #391
Merged
Upgrade EUI #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinkambic
added
chore
dependencies
justinkambic
force-pushed
the
upgrade-eui-76.4.0
branch
from
280c71b to
1178c32
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
This was referenced Mar 29, 2023
Closed
kyungeunni
reviewed
Mar 30, 2023
| @@ -80,7 +80,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@elastic/datemath": "^5.0.3", | |||
| "@elastic/eui": "^58.1.1", | |||
| "@elastic/eui": "^76.4.0", | |||
kyungeunni
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades EUI version to v76.
Implementation details
There should be minute or no GUI changes, and the app should pass all CI tests.
How to validate this change
For this particular screen, the header remains un-dimmed, whereas in previous versions of EUI it was dimmed. I've conferred with the EUI team about this and they have told me it's working as designed and although it's different from how it looked before it isn't violating any of their design principles.