Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Eject create react app #229

Closed
wants to merge 2 commits into from
Closed

Conversation

justinkambic
Copy link
Contributor

Summary

Resolves #190.

This PR tracks the WIP diff for removing create-react-app from the recorder and replacing it with dependencies that we will fully maintain. We'll be pulling changes into this branch from our forks until we get to a point where the code is in line with our goals.

Implementation details

We ran the eject script to get a baseline working solution. Goals:

  1. Get this branch passing CI
  2. Make incremental revisions to this branch via PRs from our forks
  3. When we are feeling good about the config maintenance burden, we will review and merge the overall patch

How to validate this change

Ensure the build/package scripts are working and that you can run the recorder.

@justinkambic justinkambic added chore tech debt Indicates a change we should implement to correct or modify past code/technology decisions labels Apr 27, 2022
@apmmachine
Copy link
Contributor

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-27T17:34:03.826+0000

  • Duration: 3 min 10 sec

Steps errors 1

Expand to view the steps failures

npm ci
  • Took 0 min 1 sec . View more details here
  • Description: npm ci

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@justinkambic
Copy link
Contributor Author

There's been no activity on this for some time, closing for now. If we decide to re-visit in the future we can re-open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore tech debt Indicates a change we should implement to correct or modify past code/technology decisions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Other] Explore possibility of removing create-react-app
3 participants