Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Eject create react app #220

Closed

Conversation

justinkambic
Copy link
Contributor

Summary

Resolves #190.

This contains the output of running create-react-app's eject script. This extricates create-react-app as a dependency, and moves all of its scripting and other configuration to the top-level of the repo.

This is a one-way destructive action, so if we merge this we cannot go back to create-react-app.

Implementation details

This is a draft PR that may never end up being merged. It's done to better inform our decision to either remove create-react-app or to rely on a custom fork.

How to validate this change

Will update if looking to merge

@justinkambic justinkambic self-assigned this Apr 25, 2022
@apmmachine
Copy link
Contributor

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-25T19:58:38.340+0000

  • Duration: 3 min 7 sec

Steps errors 1

Expand to view the steps failures

npm ci
  • Took 0 min 1 sec . View more details here
  • Description: npm ci

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@justinkambic
Copy link
Contributor Author

Closing this in favor of using a feature branch to allow for incremental reduction of the maintenance burden before we merge to main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Other] Explore possibility of removing create-react-app
2 participants