-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Append Kibana Security APIs #580
Conversation
I'm just seeing a single commit 7cd3567 with a change to a yaml file. Is there supposed to be some code here as well? |
Great question. There's a CLI which targets towards Kibana. When Kibana runs it cycles through the endpoints listed in the YAML. Other CLI choices would point you to a different file in our YAML folder. So appending endpoints to the YAML is sufficient. In the future, if we expand to cycle through spaces that will be non-YAML code, but the above is the stop gap on what could have already existed to setup the other conversation. |
Ah, I see. In that case, I'm not familiar with these APIs, so can't help out with this PR. |
|
Currently, the diagnostics get the alerting rules and connectors from the default space only. We'd like to have them for all spaces, so presumably the space names will end up showing up here. The diagnostics code will eventually be changed to get the list of spaces, and for each one, get all the rules and connectors from each space. |
Gotcha, that makes sense. @stefnestor the List Kibana Spaces API was introduced in elastic/kibana#21408, initial available version is 6.5.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accepting JPortner changes
Thanks, both 🎉 ! Late circling back, but changes accepted & ready for Dev approval for SupportOps to then merge. 🙏🏼 |
Co-authored-by: Joe Portner <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@pmuellr @jportner to better introspect Kibana Security/Space issues, adds APIs into Kibana diagnostic:
Kindly review
cc: @pickypg