Add support for log lines of any size and glob patterns #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
andrewkroh
reviewed
Jun 3, 2021
command/root.go
Outdated
| @@ -62,6 +62,7 @@ func ExecuteContext(ctx context.Context) error { | |||
| rootCmd.PersistentFlags().StringVarP(&opts.StartSignal, "start-signal", "s", "", "wait for start signal") | |||
| rootCmd.PersistentFlags().BoolVar(&opts.InsecureTLS, "insecure", false, "disable tls verification") | |||
| rootCmd.PersistentFlags().IntVar(&opts.RateLimit, "rate-limit", 500*1024, "bytes per second rate limit for UDP output") | |||
| rootCmd.PersistentFlags().IntVar(&opts.LogReaderBuffer, "log-reader-buf", 500*1024, "buffer size in bytes of the log reader") | |||
There was a problem hiding this comment.
This is the "maximum size of buffer that may be allocated" during log scanning, correct?
Is this needed to allow scanning lines longer than the default MaxScanTokenSize = 64 * 1024?
There was a problem hiding this comment.
Correct, until we have support for multiline I encountered cases where this is needed. Maybe defaulting to 64*1024 is enough though.
There was a problem hiding this comment.
I'm fine with making it bigger. Can you change the description to indicate this is the max.
andrewkroh
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds option to set up custom buffer size for the log reader.
Adds support for glob patterns.
Closes #8