-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HTTP server output #19
Conversation
marc-gr
commented
May 17, 2021
•
edited
Loading
edited
- Tests
- Changelog
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried it out for testing defender_atp. Worked for me. We should discuss how we want pagination and config to work.
Not sure if this is related to this output, but it hangs on SIGINT.
|
Was missing to check the cmd context, this is fixed now 👍 |
Currently this will just return the given logs in order, one request at a time, so pagination will be defined by the order of the logs you pass to the command. This ignores the request URL or any other variable in the request as its initial intent is just to send the stream of logs through an http server output. I'd like to have a more sophisticated tool that could be used to mock a specific server, with some routing and assertions, which I think is more in line with what we discussed in #9, I am unsure if this would belong here or as its own separate tool. From my testing I think this initial approach might be enough for our current needs, WDYT? |
I think all of that could be part of this tool. I think we should do the minimal required for our first set of test cases and then iterate on the development of features that we need to get the test coverage required. Since it's a test tool and primarily for our own consumption it will be fine if we need to break some of the config to refine it. |
I noticed the README lists the "outputs". Can you update it to include http-server or remove the list of outputs. |