Add gcppubsub output #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkroh
reviewed
Mar 1, 2021
There was a problem hiding this comment.
+1 to adding a test. I'd add it in this PR if you are going to do it. The tests are running with Github Actions and docker should already be present in the environment. Maybe the Go test itself could start/stop the dependent container? Or another approach would be to start it as part of the GH action workflow.
andrewkroh
approved these changes
Mar 2, 2021
|
Can you please add a changelog entry too. |
|
This has been released ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds gcppubsub output.
I would like to add some integration tests, but not sure if maybe is a good idea to do in a separate PR or what would be the preferred approach for it.
Closes https://github.com/andrewkroh/stream/issues/10