Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Add index alias definition to Stack Docs glossary #500

Merged
merged 1 commit into from
Sep 12, 2019
Merged

[DOCS] Add index alias definition to Stack Docs glossary #500

merged 1 commit into from
Sep 12, 2019

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Sep 9, 2019

Reuses the index alias definition from the Elasticsearch Reference Guide's glossary.

If successful, we can reuse this pattern for other ES glossary items.

Dependent on elastic/docs#1164. CI will fail until that PR is merged.

@jrodewig jrodewig requested review from nik9000 and lcawl September 9, 2019 12:48
@jrodewig jrodewig mentioned this pull request Sep 9, 2019
Merged
nik9000
nik9000 approved these changes Sep 9, 2019
View reviewed changes
Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrodewig jrodewig mentioned this pull request Sep 9, 2019
Closed
4 tasks
@jrodewig jrodewig marked this pull request as ready for review September 12, 2019 17:28
@jrodewig
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/docs

@jrodewig jrodewig merged commit c63788c into elastic:master Sep 12, 2019
@jrodewig jrodewig deleted the add-index-alias-to-glossary branch September 12, 2019 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nik9000 nik9000 nik9000 approved these changes

@lcawl lcawl Awaiting requested review from lcawl

Assignees
No one assigned
Labels
enhancement v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrodewig @nik9000