Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Deprecates migration assistance and upgrade APIs #247

Merged
merged 2 commits into from
Mar 15, 2019

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Mar 15, 2019

Related to elastic/elasticsearch#40072

This PR adds deprecation notes to the migration assistance and migration upgrade APIs and suggests alternative methods.

Copy link

@gwbrown gwbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple relatively minor comments, otherwise LGTM. Thank you!

and index-level settings that use deprecated features.
+
`/_xpack/migration/assistance`:: deprecated[6.7.0] Runs a series of checks on
your cluster, nodes, and indices and returns a list of issues that need to be
fixed before you can upgrade to {version}.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably say something like

`/_xpack/migration/assistance`:: deprecated[6.7.0] Returns a list of indices that need to 
be reindexed before you can upgrade to {version}.

As it doesn't actually check anything else - the description as written applies more to the migration/deprecations API.

@@ -240,33 +244,25 @@ version prior to 5.6, you must upgrade them after after installing
Elasticsearch {version}.

To get a list of the indices that need to be upgraded, install {xpack} and use
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still want to tell people to "install xpack"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I've removed that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants