Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.0 upgrade #242

Merged
merged 7 commits into from
Mar 26, 2019
Merged

7.0 upgrade #242

merged 7 commits into from
Mar 26, 2019

Conversation

debadair
Copy link
Contributor

First pass at the upgrade changes for 7.0.

@debadair debadair requested a review from lcawl March 12, 2019 23:28
Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added one more comment, but otherwise LGTM

Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @debadair!

----------------------------------------------------------
license -d @license.json
----------------------------------------------------------
. Back up your data. You **cannot roll back** to an earlier version unless
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran into a problem when I included the .kibana index in my snapshot. When I subsequently tried to restore this index it conflicted with the existing one. Can someone from @elastic/kibana-platform tell me if this was user error on my part or if it is expected?

If expected, then we should update the docs with guidance on avoiding this pitfall.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like general snapshot/restore behavior--you can't restore on top of an open index. As far as the upgrade process goes, we tell folks to back up their data, but don't really get into how to use the snapshot if the upgrade goes sideways. (I made the implicit assumption that they would understand how to use the backup if they needed to.) It might make sense to add a few words when we add the info about what to do if you have a "broken upgrade".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like general snapshot/restore behavior--you can't restore on top of an open index.

Thanks Deb! That makes sense.

It might make sense to add a few words when we add the info about what to do if you have a "broken upgrade".

Yes, that would be very helpful! Including a note about what this means for Kibana would also be helpful, I think. Something along the lines of, "Note for Kibana users: If you're restoring a snapshot that contains the .kibana index, you'll need to shut Kibana down, close the index, and restore using the command line".

----------------------------------------------------------
.. {es} Hadoop: {hadoop-ref}/install.html[install instructions]
.. {es}: {ref}/setup-upgrade.html[upgrade instructions]
.. Kibana: {kibana-ref}/upgrade.html[upgrade instructions]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per feedback from @tylersmalley, this is a little more complicated if you're using Kibana. Because Kibana comes with a new Upgrade Assistant which tells you if there are problems with your indices and cluster, the order should be:

  1. Once the user is on 6.7, go into Kibana and view the Upgrade Assistant. Address all critical items.
  2. Follow the ES upgrade steps.
  3. Follow the Kibana upgrade steps.

For context, here's what the Upgrade Assistant looks like (this screenshot may contain bugs so it's not appropriate for use in the docs):

image

@debadair debadair merged commit f323326 into elastic:7.0 Mar 26, 2019
@debadair
Copy link
Contributor Author

Will address CJ's comments in a separate PR.

debadair added a commit that referenced this pull request Mar 26, 2019
* [DOCS] First pass at 7.0 upgrade update.

* [DOCS] Fixed formatting issues & flagged the Upgrade Assistant as xpack.

* Update docs/en/install-upgrade/upgrading-stack.asciidoc

Co-Authored-By: debadair <[email protected]>

* [DOCS] Incorporated feedback from lcawl.

* [DOCS] Fixes broken link

* [DOCS] Removed tip about temporary superuser when upgrading the security index.
debadair added a commit that referenced this pull request Mar 26, 2019
* [DOCS] First pass at 7.0 upgrade update.

* [DOCS] Fixed formatting issues & flagged the Upgrade Assistant as xpack.

* Update docs/en/install-upgrade/upgrading-stack.asciidoc

Co-Authored-By: debadair <[email protected]>

* [DOCS] Incorporated feedback from lcawl.

* [DOCS] Fixes broken link

* [DOCS] Removed tip about temporary superuser when upgrading the security index.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants