-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Remove upgrade step that stops machine learning #219
Conversation
It's not related to this PR but I noticed line 26 of the file that's changed contains "IMPORTANT: 2.x indices are not compatible with {version}". The "2.x" in that bit should be whatever is two major versions earlier, so for 8.x it should be 6.x and for 7.x it should be 5.x. |
docs/upgrading-stack.asciidoc
Outdated
@@ -68,10 +68,6 @@ restart all nodes to maintain communication across the cluster. | |||
password (`changeme`). For more information, see | |||
{stack-ov}/built-in-users.html[Built-in users]. | |||
|
|||
. Stop any {ml} jobs that are running before starting the | |||
upgrade process. See | |||
{stack-ov}/stopping-ml.html[Stopping {ml}]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe instead of completely removing this section it could say something like "Consider stopping any {ml} jobs that are running - see <close_ml.asciidoc> for the pros and cons of doing this".
Or do you think that's just too complicated for this guide?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I've altered that text.
I've created #220 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR removes the step related to stopping machine learning in the Installation and Upgrade Guide (https://www.elastic.co/guide/en/elastic-stack/master/upgrading-elastic-stack.html).
Related to elastic/elasticsearch#38876