Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Adds data views to glossary #1886

Merged
merged 3 commits into from
Nov 22, 2021
Merged

[DOCS] Adds data views to glossary #1886

merged 3 commits into from
Nov 22, 2021

Conversation

gchaps
Copy link
Contributor

@gchaps gchaps commented Nov 22, 2021

This PR defines the term data views in the glossary.

This PR defines the term data views in the glossary.
Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, otherwise LGTM

docs/en/glossary/glossary.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with @lcawl's suggestion.

@gchaps gchaps merged commit b54952b into main Nov 22, 2021
@gchaps gchaps deleted the gchaps-patch-1 branch November 22, 2021 20:09
jrodewig added a commit that referenced this pull request Nov 22, 2021
Tweaks the `index pattern` definition to make it clear that it now applies to the Elasticsearch context, not Kibana.

Relates to #1886.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants