[TH: Investigations][Serverless & 8.15] New previews in expandable flyout #5605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastasha-solomon
added
Team: Threat Hunting
|
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
|
🚀 Built elastic-dot-co-docs-preview-docs successfully!
|
christineweng
previously approved these changes
Jul 25, 2024
joepeeples
previously approved these changes
Jul 26, 2024
There was a problem hiding this comment.
LGTM! One nit about capitalization but went ahead and approved in case you'd rather keep as-is.
Also, I think "summary" might work better than "preview" in some instances, because "preview" makes me think of the rule creation preview feature. But the UI uses "preview" so makes sense to stay consistent with that.
Co-authored-by: Joe Peeples <[email protected]>
nastasha-solomon
dismissed stale reviews from joepeeples and christineweng
via
72ace48
Co-authored-by: Joe Peeples <[email protected]>
joepeeples
approved these changes
Jul 26, 2024
|
Verified that the new flyouts are available in Serverless (huzzah!), so this PR is good to merge! |
mergify bot
pushed a commit
that referenced
this pull request
Jul 31, 2024
…yout (#5605) * First draft * Serverless updates * Adds serverless changes * Update entities screenshot * Updated final screenshots * Update docs/detections/alerts-view-details.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/serverless/alerts/view-alert-details.mdx Co-authored-by: Joe Peeples <[email protected]> --------- Co-authored-by: Joe Peeples <[email protected]> (cherry picked from commit 5d20347) # Conflicts: # docs/serverless/alerts/view-alert-details.mdx # docs/serverless/images/view-alert-details/-detections-expanded-correlations-view.png # docs/serverless/images/view-alert-details/-detections-expanded-entities-view.png
nastasha-solomon
added a commit
that referenced
this pull request
Jul 31, 2024
…able flyout (backport #5605) (#5634) * [TH: Investigations][Serverless & 8.15] New previews in expandable flyout (#5605) * First draft * Serverless updates * Adds serverless changes * Update entities screenshot * Updated final screenshots * Update docs/detections/alerts-view-details.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/serverless/alerts/view-alert-details.mdx Co-authored-by: Joe Peeples <[email protected]> --------- Co-authored-by: Joe Peeples <[email protected]> (cherry picked from commit 5d20347) # Conflicts: # docs/serverless/alerts/view-alert-details.mdx # docs/serverless/images/view-alert-details/-detections-expanded-correlations-view.png # docs/serverless/images/view-alert-details/-detections-expanded-entities-view.png * Delete docs/serverless directory and its contents --------- Co-authored-by: Nastasha Solomon <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5495
Previews: