Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Doc+) Alerts UI cannot be CCS [serverless] + bonus fixes #5582

Merged
merged 4 commits into from
Jul 19, 2024

Conversation

joepeeples
Copy link
Contributor

@joepeeples joepeeples commented Jul 17, 2024

Fixes included

  • Serverless twin follow-up to (Doc+) Alerts UI cannot be CCS #5513
    Adds admonition about data view picker in the Alerts page.

  • Updates the Data views in Elastic Security serverless page to match its ESS counterpart. It appears the serverless page was never updated to match ESS changes in Documents how to change the default security index #4695, so this gets ESS + serverless back in sync.

  • Fixes URL variable/attribute usage: a few links used apm-app-ref instead of kibana-ref to point to Kibana docs. Currently the two variables have the same value, so technically the links still go to the right place, but I think that in itself is an error. We should just use the Kibana variable if we want to point to Kibana docs.

  • Backports: The errant apm-app-ref attribute appears back to 8.0, but I think we can get by with fixing the current version (8.14) and moving on.

Previews

ESS:

Serverless:

  • Click the link below, then in the Security card click View serverless docs.
  • Navigate to: Explore your data → Data views in Elastic Security.

Serverless follow up to #5513
Serverless follow up to #4695
Should use `kibana-ref` instead of apm-app-ref since this has nothing to do with APM
@joepeeples joepeeples added bug Something isn't working enhancement New feature or request Feature: Data Views Feature: Alerts Docset: Serverless Issues for Serverless Security Docset: ESS Issues that apply to docs in the Stack release v8.14.0 v8.15.0 ci:doc-build labels Jul 17, 2024
@joepeeples joepeeples self-assigned this Jul 17, 2024
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@elasticdocs
Copy link

elasticdocs commented Jul 17, 2024

🚀 Built elastic-dot-co-docs-preview-docs successfully!

Issues? Visit #next-docs in Slack

@joepeeples joepeeples marked this pull request as ready for review July 17, 2024 20:38
@joepeeples joepeeples requested a review from a team as a code owner July 17, 2024 20:38
@joepeeples
Copy link
Contributor Author

run docs-build

Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joepeeples joepeeples merged commit 9e7d734 into main Jul 19, 2024
4 checks passed
mergify bot pushed a commit that referenced this pull request Jul 19, 2024
* Add admonition to serverless

Serverless follow up to #5513

* Update serverless to match ESS

Serverless follow up to #4695

* Fix URL variable/attribute

Should use `kibana-ref` instead of apm-app-ref since this has nothing to do with APM

* No-op change to trigger build

(i hope)

(cherry picked from commit 9e7d734)

# Conflicts:
#	docs/serverless/explore/data-views-in-sec.mdx
mergify bot pushed a commit that referenced this pull request Jul 19, 2024
* Add admonition to serverless

Serverless follow up to #5513

* Update serverless to match ESS

Serverless follow up to #4695

* Fix URL variable/attribute

Should use `kibana-ref` instead of apm-app-ref since this has nothing to do with APM

* No-op change to trigger build

(i hope)

(cherry picked from commit 9e7d734)

# Conflicts:
#	docs/serverless/explore/data-views-in-sec.mdx
joepeeples added a commit that referenced this pull request Jul 19, 2024
…kport #5582) (#5586)

* (Doc+) Alerts UI cannot be CCS [serverless] + bonus fixes (#5582)

* Add admonition to serverless

Serverless follow up to #5513

* Update serverless to match ESS

Serverless follow up to #4695

* Fix URL variable/attribute

Should use `kibana-ref` instead of apm-app-ref since this has nothing to do with APM

* No-op change to trigger build

(i hope)

(cherry picked from commit 9e7d734)

# Conflicts:
#	docs/serverless/explore/data-views-in-sec.mdx

* Delete docs/serverless directory and its contents

---------

Co-authored-by: Joe Peeples <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joepeeples added a commit that referenced this pull request Jul 19, 2024
…kport #5582) (#5585)

* (Doc+) Alerts UI cannot be CCS [serverless] + bonus fixes (#5582)

* Add admonition to serverless

Serverless follow up to #5513

* Update serverless to match ESS

Serverless follow up to #4695

* Fix URL variable/attribute

Should use `kibana-ref` instead of apm-app-ref since this has nothing to do with APM

* No-op change to trigger build

(i hope)

(cherry picked from commit 9e7d734)

# Conflicts:
#	docs/serverless/explore/data-views-in-sec.mdx

* Delete docs/serverless directory and its contents

---------

Co-authored-by: Joe Peeples <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@joepeeples joepeeples deleted the 5513-followup-fixes-and-serverless branch July 19, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Docset: ESS Issues that apply to docs in the Stack release Docset: Serverless Issues for Serverless Security enhancement New feature or request Feature: Alerts Feature: Data Views v8.14.0 v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants