-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.11] Adds knowledge base and Amazon Bedrock to AI Assistant docs #4149
Conversation
Documentation previews: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good content, just a few suggested edits. Thanks!
We need to decide (with @jamesspi's help) at least 2 terminology details for the knowledge base, and then standardize throughout:
- Any capitalization?
- Is it "the knowledge base" or just "knowledge base"?
IMO lowercase and including "the" seems more readable, so my suggestions do that, but we could revise if needed.
Co-authored-by: Joe Peeples <[email protected]>
Co-authored-by: Joe Peeples <[email protected]>
Co-authored-by: Joe Peeples <[email protected]>
Co-authored-by: Joe Peeples <[email protected]>
Co-authored-by: Joe Peeples <[email protected]>
Co-authored-by: Joe Peeples <[email protected]>
Co-authored-by: Joe Peeples <[email protected]>
Co-authored-by: Joe Peeples <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of questions, otherwise LGTM!
…4149) * Adds knowledge base and Amazon Bedrock to AI Assistant docs * fixes broken links * update formatting * Update security-assistant.asciidoc * formatting tweak * test build error * adds JSON permissions blob * adds missing attribute * incorporates James' feedback * Update docs/assistant/security-assistant.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/assistant/security-assistant.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/assistant/security-assistant.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/assistant/security-assistant.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/assistant/security-assistant.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/assistant/security-assistant.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/assistant/security-assistant.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/assistant/security-assistant.asciidoc Co-authored-by: Joe Peeples <[email protected]> * incorporates final feedback --------- Co-authored-by: Joe Peeples <[email protected]> (cherry picked from commit 834fd24)
…4149) (#4202) * Adds knowledge base and Amazon Bedrock to AI Assistant docs * fixes broken links * update formatting * Update security-assistant.asciidoc * formatting tweak * test build error * adds JSON permissions blob * adds missing attribute * incorporates James' feedback * Update docs/assistant/security-assistant.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/assistant/security-assistant.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/assistant/security-assistant.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/assistant/security-assistant.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/assistant/security-assistant.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/assistant/security-assistant.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/assistant/security-assistant.asciidoc Co-authored-by: Joe Peeples <[email protected]> * Update docs/assistant/security-assistant.asciidoc Co-authored-by: Joe Peeples <[email protected]> * incorporates final feedback --------- Co-authored-by: Joe Peeples <[email protected]> (cherry picked from commit 834fd24) Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
Fixes #4031 and fixes #4039 by updating the AI Assistant docs to include the Amazon Bedrock connector and the Knowledge base.
Preview: Elastic AI Assistant