Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.11] Adds knowledge base and Amazon Bedrock to AI Assistant docs #4149

Merged
merged 22 commits into from
Nov 7, 2023

Conversation

benironside
Copy link
Contributor

@benironside benironside commented Nov 1, 2023

Fixes #4031 and fixes #4039 by updating the AI Assistant docs to include the Amazon Bedrock connector and the Knowledge base.

Preview: Elastic AI Assistant

@benironside benironside added Feature: Elastic AI Assistant Interface for interacting with generative AIs v8.11.0 labels Nov 1, 2023
@benironside benironside self-assigned this Nov 1, 2023
Copy link

github-actions bot commented Nov 1, 2023

Documentation previews:

@benironside benironside requested a review from a team November 2, 2023 19:07
Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good content, just a few suggested edits. Thanks!

We need to decide (with @jamesspi's help) at least 2 terminology details for the knowledge base, and then standardize throughout:

  • Any capitalization?
  • Is it "the knowledge base" or just "knowledge base"?

IMO lowercase and including "the" seems more readable, so my suggestions do that, but we could revise if needed.

docs/assistant/security-assistant.asciidoc Outdated Show resolved Hide resolved
docs/assistant/security-assistant.asciidoc Outdated Show resolved Hide resolved
docs/assistant/security-assistant.asciidoc Outdated Show resolved Hide resolved
docs/assistant/security-assistant.asciidoc Outdated Show resolved Hide resolved
docs/assistant/security-assistant.asciidoc Outdated Show resolved Hide resolved
docs/assistant/security-assistant.asciidoc Outdated Show resolved Hide resolved
docs/assistant/security-assistant.asciidoc Outdated Show resolved Hide resolved
docs/assistant/security-assistant.asciidoc Outdated Show resolved Hide resolved
@benironside benironside requested a review from a team November 2, 2023 21:38
Copy link
Contributor

@natasha-moore-elastic natasha-moore-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of questions, otherwise LGTM!

docs/assistant/security-assistant.asciidoc Outdated Show resolved Hide resolved
docs/assistant/security-assistant.asciidoc Outdated Show resolved Hide resolved
@benironside benironside mentioned this pull request Nov 3, 2023
15 tasks
@benironside benironside merged commit 834fd24 into main Nov 7, 2023
1 check passed
mergify bot pushed a commit that referenced this pull request Nov 7, 2023
…4149)

* Adds knowledge base and Amazon Bedrock to AI Assistant docs

* fixes broken links

* update formatting

* Update security-assistant.asciidoc

* formatting tweak

* test build error

* adds JSON permissions blob

* adds missing attribute

* incorporates James' feedback

* Update docs/assistant/security-assistant.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/assistant/security-assistant.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/assistant/security-assistant.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/assistant/security-assistant.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/assistant/security-assistant.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/assistant/security-assistant.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/assistant/security-assistant.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/assistant/security-assistant.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* incorporates final feedback

---------

Co-authored-by: Joe Peeples <[email protected]>
(cherry picked from commit 834fd24)
benironside added a commit that referenced this pull request Nov 7, 2023
…4149) (#4202)

* Adds knowledge base and Amazon Bedrock to AI Assistant docs

* fixes broken links

* update formatting

* Update security-assistant.asciidoc

* formatting tweak

* test build error

* adds JSON permissions blob

* adds missing attribute

* incorporates James' feedback

* Update docs/assistant/security-assistant.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/assistant/security-assistant.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/assistant/security-assistant.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/assistant/security-assistant.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/assistant/security-assistant.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/assistant/security-assistant.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/assistant/security-assistant.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/assistant/security-assistant.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* incorporates final feedback

---------

Co-authored-by: Joe Peeples <[email protected]>
(cherry picked from commit 834fd24)

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Elastic AI Assistant Interface for interacting with generative AIs v8.11.0
Projects
Development

Successfully merging this pull request may close these issues.

Knowledge Base for AI Assistant New Amazon Bedrock Connector
5 participants