-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates images and documents new dashboards and filters #3784
Conversation
Documentation previews: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for updating the doc @benironside ! LGTM!
Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
This pull request is now in conflicts. Could you fix it @benironside? 🙏
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some super minor suggestions. Overall, LGTM!
Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
…elastic/security-docs into 3620-8.10-dashboards-ui-updates test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few suggestions, thanks!
Let me know if you have any questions about single-sourcing the screenshot. AsciiDoc is, of course, kind of tricky with that: you can usually use the same syntax in both files (image::images/file-name.png[blah]
), but the preview in VS Code might not display correctly for one of them. BUT, once you run the docs build (locally or a PR's CI), the image should display correctly on both pages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should single-source this screenshot, so we have only one file to maintain for future UI changes. Also, the image appears really big in both pages were it's included, so I'd adjust the width syntax to about 60%.
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
incorporated Joe's feedback by single-sourcing the image
* Updates images and documents new dashboards and filters * Adds more detail, links to other resources * Update docs/dashboards/dashboards-overview.asciidoc Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com> * Update docs/dashboards/dashboards-overview.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/dashboards/dashboards-overview.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/dashboards/dashboards-overview.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * updates images for new UI * Update docs/dashboards/dashboards-overview.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/dashboards/dashboards-overview.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * single-sources image * adjust image size --------- Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com> Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> Co-authored-by: Joe Peeples <joe.peeples@elastic.co> (cherry picked from commit 051ee0d)
* Updates images and documents new dashboards and filters * Adds more detail, links to other resources * Update docs/dashboards/dashboards-overview.asciidoc Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com> * Update docs/dashboards/dashboards-overview.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/dashboards/dashboards-overview.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/dashboards/dashboards-overview.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * updates images for new UI * Update docs/dashboards/dashboards-overview.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/dashboards/dashboards-overview.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * single-sources image * adjust image size --------- Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com> Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> Co-authored-by: Joe Peeples <joe.peeples@elastic.co> (cherry picked from commit 051ee0d) Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
Fixes #3620 by updating dashboards page screenshots, and documenting the new filter functionality on the Dashboards landing page.
Previews: