-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove breaking changes tags #3656
Merged
jrodewig
merged 2 commits into
elastic:main
from
jrodewig:jrodewig/remove-breaking-change-tags
Aug 1, 2023
Merged
Remove breaking changes tags #3656
jrodewig
merged 2 commits into
elastic:main
from
jrodewig:jrodewig/remove-breaking-change-tags
Aug 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation previews: |
nastasha-solomon
approved these changes
Aug 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggested removing the locally-scoped pull request attribute since we no longer need it. Everything else LGTM! Thanks, @jrodewig!
These changes LGTM @jrodewig - thanks! |
jmikell821
approved these changes
Aug 1, 2023
mergify bot
pushed a commit
that referenced
this pull request
Aug 1, 2023
With elastic/stack-docs#2495 merged, we no longer need tags to reuse breaking changes in the Stack Install/Upgrade guide. (cherry picked from commit cc19a1f)
jrodewig
added a commit
that referenced
this pull request
Aug 1, 2023
Co-authored-by: James Rodewig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With elastic/stack-docs#2495 merged, we no longer need tags to reuse breaking changes in the Stack Install/Upgrade guide.