-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elastic Security Assistant initial docs (8.8.1) #3425
Conversation
Documentation previews: |
This comment was marked as resolved.
This comment was marked as resolved.
Hey @joepeeples This is looking great! Perhaps we could squeeze in a quick gif? To answer your Q's:
We're going for Elastic Security Assistant for 8.8.1. It's fine to shorter in to Security Assistant.
I don't think it matters too much. Did you have a place In mind where you wanted to reference it as such? |
There are a couple of animated gifs in the page; I added them in the last commit so maybe you viewed the preview before CI had published that commit? But if you'd like another gif showing some other process, just let me know and we can figure it out.
I used "the Security Assistant" pretty consistently throughout the draft, so I was just confirming that's OK for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating this @joepeeples! It's a great first iteration and I think it'll be helpful for getting users off the ground so they can tinker with the Security Assistant.
I left some suggestions for your consideration. Otherwise, it LGTM!
@joepeeples Indeed, I see the gifs now, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two comments for part 1 of feedback.
Co-authored-by: Nastasha Solomon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an awesome first iteration!!! Thanks @joepeeples ⭐
Co-authored-by: Janeen Mikell Roberts <[email protected]> Co-authored-by: Nastasha Solomon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs LGTM! 👍 Thanks so much @joepeeples! 😀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
* First draft, text only * Add images, a few edits * Apply suggestions from Nastasha's review Co-authored-by: Nastasha Solomon <[email protected]> * Apply suggestions from Janeen & Nastasha's review Co-authored-by: Janeen Mikell Roberts <[email protected]> Co-authored-by: Nastasha Solomon <[email protected]> * Moar suggestions from code review * One more edit --------- Co-authored-by: Nastasha Solomon <[email protected]> Co-authored-by: Janeen Mikell Roberts <[email protected]> (cherry picked from commit 8b55048)
* First draft, text only * Add images, a few edits * Apply suggestions from Nastasha's review Co-authored-by: Nastasha Solomon <[email protected]> * Apply suggestions from Janeen & Nastasha's review Co-authored-by: Janeen Mikell Roberts <[email protected]> Co-authored-by: Nastasha Solomon <[email protected]> * Moar suggestions from code review * One more edit --------- Co-authored-by: Nastasha Solomon <[email protected]> Co-authored-by: Janeen Mikell Roberts <[email protected]> (cherry picked from commit 8b55048) Co-authored-by: Joe Peeples <[email protected]>
Resolves #3420.
Preview: Security Assistant
Notes
EDIT: removed Open Questions, which are now Answered Questions below.