-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alerts can be shared via a shareable URL #3264
Conversation
Documentation previews: |
Only other thing is I think that needs to be done is updating the screenshot 😄 |
…-docs into issue-3184-share-alerts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks Nastasha! LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, added a few nits. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Didn't find much to add to Joe's review.
Co-authored-by: Joe Peeples <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slight suggestion but looks great, thanks!
Co-authored-by: Janeen Mikell Roberts <[email protected]>
Co-authored-by: Janeen Mikell Roberts <[email protected]>
Co-authored-by: Joe Peeples <[email protected]> Co-authored-by: Janeen Mikell Roberts <[email protected]> (cherry picked from commit 32bfbd9)
Co-authored-by: Joe Peeples <[email protected]> Co-authored-by: Janeen Mikell Roberts <[email protected]> Co-authored-by: Nastasha Solomon <[email protected]>
Fixes #3184.
Previews:
kibana.alert.url
field. Also refreshed screenshot.kibana.alert.url
field (see the last row)