Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerts can be shared via a shareable URL #3264

Merged
merged 15 commits into from
May 22, 2023
Merged

Conversation

nastasha-solomon
Copy link
Contributor

@nastasha-solomon nastasha-solomon commented May 14, 2023

Fixes #3184.

Previews:

  • View detection alert details: Added explanation of how to use the Share alert button and the new kibana.alert.url field. Also refreshed screenshot.
  • Alert schema: Added the new kibana.alert.url field (see the last row)

@github-actions
Copy link

Documentation previews:

@nastasha-solomon nastasha-solomon marked this pull request as ready for review May 15, 2023 13:40
@michaelolo24
Copy link

Only other thing is I think that needs to be done is updating the screenshot 😄

@nastasha-solomon nastasha-solomon changed the title Alerts can be shared via a shareable URL #3184 Alerts can be shared via a shareable URL May 16, 2023
Copy link

@michaelolo24 michaelolo24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks Nastasha! LGTM 🚀

Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, added a few nits. Thanks!

docs/detections/alerts-view-details.asciidoc Outdated Show resolved Hide resolved
docs/detections/alerts-view-details.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Didn't find much to add to Joe's review.

docs/detections/alerts-view-details.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight suggestion but looks great, thanks!

docs/detections/alerts-view-details.asciidoc Outdated Show resolved Hide resolved
docs/detections/alerts-view-details.asciidoc Outdated Show resolved Hide resolved
@nastasha-solomon nastasha-solomon merged commit 32bfbd9 into main May 22, 2023
mergify bot pushed a commit that referenced this pull request May 22, 2023
Co-authored-by: Joe Peeples <[email protected]>
Co-authored-by: Janeen Mikell Roberts <[email protected]>
(cherry picked from commit 32bfbd9)
nastasha-solomon added a commit that referenced this pull request May 22, 2023
Co-authored-by: Joe Peeples <[email protected]>
Co-authored-by: Janeen Mikell Roberts <[email protected]>
Co-authored-by: Nastasha Solomon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alerts can be shared via a shareable URL
5 participants