Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert summaries and conditional actions #3245

Merged
merged 49 commits into from
May 22, 2023

Conversation

nastasha-solomon
Copy link
Contributor

@nastasha-solomon nastasha-solomon commented May 9, 2023

Fixes #3142.

Preview:

@github-actions
Copy link

github-actions bot commented May 9, 2023

Documentation previews:

@nastasha-solomon nastasha-solomon requested a review from e40pud May 9, 2023 23:15
@nastasha-solomon nastasha-solomon marked this pull request as ready for review May 9, 2023 23:16
docs/detections/rules-ui-create.asciidoc Outdated Show resolved Hide resolved
docs/detections/rules-ui-create.asciidoc Outdated Show resolved Hide resolved
docs/detections/rules-ui-create.asciidoc Outdated Show resolved Hide resolved
docs/detections/rules-ui-create.asciidoc Outdated Show resolved Hide resolved
@nastasha-solomon nastasha-solomon requested a review from e40pud May 11, 2023 04:11
docs/detections/rules-ui-create.asciidoc Outdated Show resolved Hide resolved
docs/detections/rules-ui-create.asciidoc Outdated Show resolved Hide resolved
docs/detections/rules-ui-manage.asciidoc Outdated Show resolved Hide resolved
nastasha-solomon and others added 15 commits May 21, 2023 11:41
Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good feedback left, especially per the alert summaries. Thanks for pulling this together!

docs/detections/rules-ui-create.asciidoc Outdated Show resolved Hide resolved
@mergify
Copy link
Contributor

mergify bot commented May 22, 2023

This pull request is now in conflicts. Could you fix it @nastasha-solomon? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b issue-3142-actions-alert-sum upstream/issue-3142-actions-alert-sum
git merge upstream/main
git push upstream issue-3142-actions-alert-sum

@nastasha-solomon nastasha-solomon merged commit 2331998 into main May 22, 2023
mergify bot pushed a commit that referenced this pull request May 22, 2023
Co-authored-by: Ievgen Sorokopud <[email protected]>
Co-authored-by: Joe Peeples <[email protected]>
Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
(cherry picked from commit 2331998)
nastasha-solomon added a commit that referenced this pull request May 22, 2023
Co-authored-by: Ievgen Sorokopud <[email protected]>
Co-authored-by: Joe Peeples <[email protected]>
Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
Co-authored-by: Nastasha Solomon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alert summaries and conditional actions
8 participants