Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snoozing alert notifications for detection rules #3217

Merged
merged 22 commits into from
May 18, 2023
Merged

Snoozing alert notifications for detection rules #3217

merged 22 commits into from
May 18, 2023

Conversation

nastasha-solomon
Copy link
Contributor

@nastasha-solomon nastasha-solomon commented May 3, 2023 •
edited
Loading

Fixes #3146.

Previews:

  • Manage detection rules: Added link to the new section for snoozing rule actions.
  • Modify existing rule settings: Added tip that users can snooze rule actions while editing a rule.
  • Manage rules: Added line to section intro and step 2 letting users know that they could snooze rule actions from the Rules table.
  • Snooze rule actions: New section that explains what snoozing is, how it works, and where users can snooze rule actions.

@nastasha-solomon nastasha-solomon self-assigned this May 3, 2023
@github-actions
Copy link

github-actions bot commented May 3, 2023

Documentation previews:

@nastasha-solomon nastasha-solomon requested a review from maximpn May 10, 2023 00:09
@nastasha-solomon nastasha-solomon marked this pull request as ready for review May 10, 2023 00:09
maximpn
maximpn approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@maximpn maximpn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nastasha-solomon nastasha-solomon mentioned this pull request May 16, 2023
Closed
nastasha-solomon
nastasha-solomon commented May 17, 2023
View reviewed changes
docs/detections/rules-ui-manage.asciidoc Outdated Show resolved Hide resolved
docs/detections/rules-ui-manage.asciidoc Outdated Show resolved Hide resolved
docs/detections/rules-ui-manage.asciidoc Outdated Show resolved Hide resolved
docs/detections/rules-ui-manage.asciidoc Outdated Show resolved Hide resolved
jmikell821
jmikell821 reviewed May 17, 2023
View reviewed changes
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You gave yourself great suggestions! I just have one thing to add.

docs/detections/rules-ui-manage.asciidoc Outdated Show resolved Hide resolved
benironside
benironside reviewed May 18, 2023
View reviewed changes
Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and accurate! Left a few minor suggestions for your consideration

docs/detections/rules-ui-manage.asciidoc Outdated Show resolved Hide resolved
docs/detections/rules-ui-manage.asciidoc Outdated Show resolved Hide resolved
docs/detections/rules-ui-manage.asciidoc Outdated Show resolved Hide resolved
nastasha-solomon and others added 3 commits May 18, 2023 14:50
@nastasha-solomon @benironside
Update docs/detections/rules-ui-manage.asciidoc
679d7b3 
Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
@nastasha-solomon @benironside
Update docs/detections/rules-ui-manage.asciidoc
0c64e42 
Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
@nastasha-solomon @benironside
Update docs/detections/rules-ui-manage.asciidoc
71bb3ba 
Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
@nastasha-solomon nastasha-solomon merged commit b9c19c0 into main May 18, 2023
@nastasha-solomon nastasha-solomon deleted the issue-3146-rule-snoozing branch May 18, 2023 19:06
mergify bot pushed a commit that referenced this pull request May 18, 2023
@nastasha-solomon @mergify
Snoozing alert notifications for detection rules (#3217)
2fc0732 
Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
(cherry picked from commit b9c19c0)
@mergify mergify bot mentioned this pull request May 18, 2023
Merged
nastasha-solomon added a commit that referenced this pull request May 18, 2023
@mergify @benironside @nastasha-solomon
[8.8] Snoozing alert notifications for detection rules (backport #3217)…
6dbe2ef 
… (#3308)

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
Co-authored-by: Nastasha Solomon <[email protected]>
@nastasha-solomon nastasha-solomon mentioned this pull request May 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benironside benironside benironside left review comments

@jmikell821 jmikell821 jmikell821 left review comments

@maximpn maximpn maximpn approved these changes

@joepeeples joepeeples Awaiting requested review from joepeeples

Assignees

@nastasha-solomon nastasha-solomon

Labels
Feature: Rules Team: Detections/Response Detections and Response v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Snoozing alert notifications for detection rules
4 participants
@nastasha-solomon @maximpn @jmikell821 @benironside