Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Entity dashboard #2565

Merged
merged 5 commits into from
Oct 20, 2022
Merged

[DOCS] Entity dashboard #2565

merged 5 commits into from
Oct 20, 2022

Conversation

jmikell821
Copy link
Contributor

@jmikell821 jmikell821 commented Oct 11, 2022

Resolves #2517.

Preview here.

@jmikell821 jmikell821 added Team: Threat Hunting Formerly Data Visibility Feature: Dashboards v8.5.0 Feature: Entity Analytics Features or enhancements for any of the Entity pages labels Oct 11, 2022
@jmikell821 jmikell821 requested a review from SourinPaul October 11, 2022 21:41
@jmikell821 jmikell821 self-assigned this Oct 11, 2022
@github-actions
Copy link

Documentation previews:

docs/dashboards/entity-dashboard.asciidoc Outdated Show resolved Hide resolved
docs/dashboards/entity-dashboard.asciidoc Outdated Show resolved Hide resolved
docs/dashboards/entity-dashboard.asciidoc Outdated Show resolved Hide resolved
docs/dashboards/entity-dashboard.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, left some minor suggestions for your consideration. Some may be a bit nitpicky so please feel free to "resolve". Nice use of the requirements block, and I like the tip at the bottom.

docs/dashboards/entity-dashboard.asciidoc Outdated Show resolved Hide resolved
docs/dashboards/entity-dashboard.asciidoc Outdated Show resolved Hide resolved
docs/dashboards/entity-dashboard.asciidoc Outdated Show resolved Hide resolved
docs/dashboards/entity-dashboard.asciidoc Outdated Show resolved Hide resolved
docs/dashboards/entity-dashboard.asciidoc Outdated Show resolved Hide resolved
docs/dashboards/entity-dashboard.asciidoc Outdated Show resolved Hide resolved
docs/dashboards/entity-dashboard.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments, thanks!

docs/dashboards/entity-dashboard.asciidoc Outdated Show resolved Hide resolved
docs/dashboards/entity-dashboard.asciidoc Outdated Show resolved Hide resolved
docs/dashboards/entity-dashboard.asciidoc Outdated Show resolved Hide resolved
docs/dashboards/entity-dashboard.asciidoc Outdated Show resolved Hide resolved
docs/dashboards/entity-dashboard.asciidoc Outdated Show resolved Hide resolved
docs/dashboards/entity-dashboard.asciidoc Outdated Show resolved Hide resolved
docs/dashboards/entity-dashboard.asciidoc Outdated Show resolved Hide resolved
docs/dashboards/entity-dashboard.asciidoc Outdated Show resolved Hide resolved
docs/dashboards/entity-dashboard.asciidoc Outdated Show resolved Hide resolved
docs/dashboards/entity-dashboard.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some light edits, looks great overall!

docs/dashboards/entity-dashboard.asciidoc Outdated Show resolved Hide resolved
docs/dashboards/entity-dashboard.asciidoc Outdated Show resolved Hide resolved
docs/dashboards/entity-dashboard.asciidoc Outdated Show resolved Hide resolved
docs/dashboards/entity-dashboard.asciidoc Outdated Show resolved Hide resolved
@jmikell821 jmikell821 added the readyforQA PRs that are ready for QA review. label Oct 18, 2022
@jmikell821 jmikell821 mentioned this pull request Oct 18, 2022
28 tasks
@ghost
Copy link

ghost commented Oct 18, 2022

Hi @jmikell821 ,

We have validated above preview link and found an issue.

We will re-validate this PR once above issue is fixed.

Thanks !

@jmikell821
Copy link
Contributor Author

Hi @jmikell821 ,

We have validated above preview link and found an issue.

We will re-validate this PR once above issue is fixed.

Thanks !

Hi @karanverma-qasource -- yes, I added a comment to myself here as a reminder. Once #2580 is merged, I'll add the anchor ref link to the topic here.

@jmikell821 jmikell821 merged commit e14b18d into main Oct 20, 2022
mergify bot pushed a commit that referenced this pull request Oct 20, 2022
* Adding content for the entity dashboard.

* Merging round 1 of feedback.

* Update entity-dashboard.asciidoc

* Adding host risk score reference.

(cherry picked from commit e14b18d)
jmikell821 added a commit that referenced this pull request Oct 21, 2022
* Adding content for the entity dashboard.

* Merging round 1 of feedback.

* Update entity-dashboard.asciidoc

* Adding host risk score reference.

(cherry picked from commit e14b18d)

Co-authored-by: Janeen Mikell-Straughn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Dashboards Feature: Entity Analytics Features or enhancements for any of the Entity pages readyforQA PRs that are ready for QA review. Team: Threat Hunting Formerly Data Visibility v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] Add Entity analytics dashboard
7 participants