Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Threat Intelligence - Indicators Page and Indicator Details #2526

Merged
merged 76 commits into from
Oct 18, 2022
Merged

[DOCS] Threat Intelligence - Indicators Page and Indicator Details #2526

merged 76 commits into from
Oct 18, 2022

Conversation

nastasha-solomon
Copy link
Contributor

@nastasha-solomon nastasha-solomon commented Oct 3, 2022 •
edited
Loading

Fixes #2497.

Previews:

@nastasha-solomon nastasha-solomon self-assigned this Oct 3, 2022
@github-actions
Copy link

github-actions bot commented Oct 3, 2022

Documentation previews:

@nastasha-solomon nastasha-solomon marked this pull request as ready for review October 4, 2022 17:28
benironside
benironside reviewed Oct 4, 2022
View reviewed changes
Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great 🚀 . Left a few sentence-level suggestions.

docs/events/indicators-of-compromise.asciidoc Outdated Show resolved Hide resolved
docs/events/indicators-of-compromise.asciidoc Outdated Show resolved Hide resolved
docs/events/indicators-of-compromise.asciidoc Outdated Show resolved Hide resolved
docs/events/indicators-of-compromise.asciidoc Outdated Show resolved Hide resolved
docs/events/indicators-of-compromise.asciidoc Outdated Show resolved Hide resolved
docs/events/indicators-of-compromise.asciidoc Outdated Show resolved Hide resolved
nastasha-solomon and others added 2 commits October 4, 2022 17:43
nastasha-solomon
nastasha-solomon commented Oct 17, 2022
View reviewed changes
Copy link
Contributor Author

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional edits from joe and dhru

docs/cases/indicators-of-compromise.asciidoc Outdated Show resolved Hide resolved
docs/cases/indicators-of-compromise.asciidoc Outdated Show resolved Hide resolved
@nastasha-solomon nastasha-solomon added the readyforQA PRs that are ready for QA review. label Oct 17, 2022
@ghost
Copy link

ghost commented Oct 18, 2022

Hi @nastasha-solomon

We have reviewed the shared preview for Threat Intelligence - Indicators Page and Indicator Details and all the required changes are present and correct. ✔️

Screenshots:
indicator-details-flyout
indicator-in-timeline
indicators-table
Screenshot (1075)
Screenshot (1076)

Indicators.of.compromise._.Elastic.Security.Solution.master._.Elastic.-.Google.Chrome.2022-10-18.13-23-54.mp4

Hence we are adding "QA:Validated" label to it.

Thanks!

@ghost ghost added QA:Validated Issue has been Validated by QA Team and removed readyforQA PRs that are ready for QA review. labels Oct 18, 2022
@joepeeples joepeeples mentioned this pull request Oct 18, 2022
Merged
jmikell821
jmikell821 reviewed Oct 18, 2022
View reviewed changes
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two slight nits, then good to go! Thanks!

docs/cases/indicators-of-compromise.asciidoc Show resolved Hide resolved
docs/cases/indicators-of-compromise.asciidoc Outdated Show resolved Hide resolved
@nastasha-solomon nastasha-solomon merged commit 16180a9 into main Oct 18, 2022
@nastasha-solomon nastasha-solomon deleted the issue-2497-TIP branch October 18, 2022 21:11
mergify bot pushed a commit that referenced this pull request Oct 18, 2022
@nastasha-solomon @mergify
[DOCS] Threat Intelligence - Indicators Page and Indicator Details (#…
1327ceb 
…2526)

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
Co-authored-by: Joe Peeples <[email protected]>
Co-authored-by: Maxim Kholod <[email protected]>
Co-authored-by: Janeen Mikell-Straughn <[email protected]>
(cherry picked from commit 16180a9)
@mergify mergify bot mentioned this pull request Oct 18, 2022
Merged
nastasha-solomon added a commit that referenced this pull request Oct 18, 2022
@mergify @benironside
@joepeeples @maxcold @jmikell821 @nastasha-solomon
[8.5] [DOCS] Threat Intelligence - Indicators Page and Indicator Deta…
78eaddb 
…ils (backport #2526) (#2598)

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
Co-authored-by: Joe Peeples <[email protected]>
Co-authored-by: Maxim Kholod <[email protected]>
Co-authored-by: Janeen Mikell-Straughn <[email protected]>
Co-authored-by: nastasha-solomon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhru42 dhru42 dhru42 left review comments

@joepeeples joepeeples joepeeples left review comments

@jmikell821 jmikell821 jmikell821 left review comments

@PhilippeOberti PhilippeOberti PhilippeOberti left review comments

@maxcold maxcold maxcold left review comments

@benironside benironside Awaiting requested review from benironside

Assignees

@nastasha-solomon nastasha-solomon

Labels
QA:Validated Issue has been Validated by QA Team Team: Docs Team: Protections Experience v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOCS] Threat Intelligence - Indicators Page and Indicator Details
7 participants
@nastasha-solomon @maxcold @dhru42 @PhilippeOberti @jmikell821 @joepeeples @benironside