Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] What's new in 8.3 #2155

Merged
merged 7 commits into from
Jun 28, 2022
Merged

[DOCS] What's new in 8.3 #2155

merged 7 commits into from
Jun 28, 2022

Conversation

jmikell821
Copy link
Contributor

Resolves #2052

Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, there's a lot here and I think users will be happy to learn of it. I left some suggestions for your consideration, including one that should fix the build WARNING at line 49, but I couldn't figure out the other warning (something about the tag that starts on line 11 🤔 )

docs/whats-new.asciidoc Outdated Show resolved Hide resolved
docs/whats-new.asciidoc Outdated Show resolved Hide resolved
docs/whats-new.asciidoc Outdated Show resolved Hide resolved
docs/whats-new.asciidoc Outdated Show resolved Hide resolved
docs/whats-new.asciidoc Outdated Show resolved Hide resolved
docs/whats-new.asciidoc Outdated Show resolved Hide resolved
docs/whats-new.asciidoc Outdated Show resolved Hide resolved
docs/whats-new.asciidoc Outdated Show resolved Hide resolved
docs/whats-new.asciidoc Outdated Show resolved Hide resolved
docs/whats-new.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a handful of comments. Looks great overall, thank you!

docs/whats-new.asciidoc Outdated Show resolved Hide resolved
docs/whats-new.asciidoc Outdated Show resolved Hide resolved
docs/whats-new.asciidoc Outdated Show resolved Hide resolved
docs/whats-new.asciidoc Outdated Show resolved Hide resolved
docs/whats-new.asciidoc Outdated Show resolved Hide resolved
docs/whats-new.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a handful of comments. Looks great overall, thank you!

Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments for small details, LGTM! We really had a lot go into this release! 😅

docs/whats-new.asciidoc Outdated Show resolved Hide resolved
docs/whats-new.asciidoc Outdated Show resolved Hide resolved
docs/whats-new.asciidoc Outdated Show resolved Hide resolved
docs/whats-new.asciidoc Outdated Show resolved Hide resolved
docs/whats-new.asciidoc Show resolved Hide resolved
@lcawl
Copy link
Contributor

lcawl commented Jun 28, 2022

@elasticmachine run elasticsearch-ci/docs

docs/whats-new.asciidoc Outdated Show resolved Hide resolved
@jmikell821 jmikell821 merged commit 5b9676a into main Jun 28, 2022
mergify bot pushed a commit that referenced this pull request Jun 28, 2022
* Adding edits to what's new.

* Merging feedback.

* Modified user risk score text.

* Merging add'l feedback.

* Merging feedback; attempting to fix build error.

* Update docs/whats-new.asciidoc

Co-authored-by: Lisa Cawley <[email protected]>
(cherry picked from commit 5b9676a)
jmikell821 added a commit that referenced this pull request Jun 28, 2022
* Adding edits to what's new.

* Merging feedback.

* Modified user risk score text.

* Merging add'l feedback.

* Merging feedback; attempting to fix build error.

* Update docs/whats-new.asciidoc

Co-authored-by: Lisa Cawley <[email protected]>
(cherry picked from commit 5b9676a)

Co-authored-by: Janeen Mikell-Straughn <[email protected]>
@nastasha-solomon nastasha-solomon deleted the whats-new-8.3 branch July 18, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] What's new in 8.3
5 participants