-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Osquery enhancements to the Alerts table and alert details flyout #2087
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks @nastasha-solomon!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions, thanks!
Co-authored-by: Joe Peeples <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only have two small nits - LGTM! 👍
Co-authored-by: Janeen Mikell-Straughn <[email protected]>
Hi @jmikell821 Thanks for all the updates. 🟢 User is now available to run the Osquery from the more actions menu as mentioned on the Step-1 in the documentation. 🔴 In the Step-3 the Screenshot of the Run Osquery is incorrect . Actual ResultExpected Result🟢 The Result format under Run Osquery is shown same as mentioned in the Step 7 where account for the new options to 🔴 There is no Step-8 is mentioned in the documentation related to screenshot. ScreenshotWe will be revalidating this PR once the above issue get Fixed. Thanks! |
…rity-docs into issue-2060-osquery-timeline
Hi @akanshachoudhary-qasource thanks for checking this! I updated the screenshot under step 3 and verified with @tomsonpl that it was the correct one. Please take a look when you have a chance. Also, would you mind elaborating on the eighth step that you said is missing? After users run the query, there's a number of things they can do with the results so I left the task open-ended to convey that. |
Thanks for the update. Please find the below observations
Apologies for the confusion, in first comment of this ticket, it is mentioned
and we thought there must be a Hence we are adding Thanks! |
…out (#2087) Co-authored-by: Joe Peeples <[email protected]> Co-authored-by: Janeen Mikell-Straughn <[email protected]> (cherry picked from commit d032712)
…ls flyout (backport #2087) (#2153) Co-authored-by: Joe Peeples <[email protected]> Co-authored-by: Janeen Mikell-Straughn <[email protected]> Co-authored-by: nastasha-solomon <[email protected]>
Fixes #2060 and #2103.
Made a few updates:
Preview here.