-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] New page: Detection & Response dashboard #2085
[DOCS] New page: Detection & Response dashboard #2085
Conversation
- Create new section: Dashboards - Move Overview page to new topic within Dashboards - Create new topic for D&R dashboard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some minor editorial suggestions for your consideration. Looks great overall and good idea to create new topics for the dashboards!
Hi @stephmilovic and @jamster10 - please review this PR when you have a moment - thanks! |
@jmikell821 , @joepeeples Thanks for writing this all up. It looks really good! :D. Going forward, Let me know if there are things I can do on my end to make your job easier- one thing for sure is as we build and expectation changes with design and product, Ill be sure to update the original ticket so the docs team knows of any changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an epic PR, absolute 🔥. I left kind of a lot of suggestions, I hope they are helpful.
we have validated the preview page and all changes are correct and good to go ✔️ Fixed Areas:
|
Co-authored-by: benironside <[email protected]> Co-authored-by: nastasha-solomon <[email protected]>
Co-authored-by: benironside <[email protected]>
Co-authored-by: benironside <[email protected]>
Thanks @jamster10! Tagging us (@elastic/security-docs) on issues/epics/PRs is a great way to keep us in the loop, and please invite the team to any demos or similar design/dev events. There's a lot of exciting stuff happening with these dashboards, navigation, etc. and we love to get sneak peeks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great feedback from the team! I only have a few slight suggestions. LGTM - thanks! 🎉
Co-authored-by: Janeen Mikell-Straughn <[email protected]>
This pull request is now in conflicts. Could you fix it @joepeeples? 🙏
|
* First draft - Create new section: Dashboards - Move Overview page to new topic within Dashboards - Create new topic for D&R dashboard * Update collapse-side-nav-button.gif * Apply suggestions from code review Co-authored-by: benironside <[email protected]> Co-authored-by: nastasha-solomon <[email protected]> * Additional suggestions from code review Co-authored-by: benironside <[email protected]> * Update docs/getting-started/security-ui.asciidoc Co-authored-by: benironside <[email protected]> * Apply suggestions from code review * Update docs/dashboards/overview-dashboard.asciidoc * Apply suggestions from Janeen's review Co-authored-by: Janeen Mikell-Straughn <[email protected]> Co-authored-by: benironside <[email protected]> Co-authored-by: nastasha-solomon <[email protected]> Co-authored-by: Janeen Mikell-Straughn <[email protected]> (cherry picked from commit 0619d16)
* First draft - Create new section: Dashboards - Move Overview page to new topic within Dashboards - Create new topic for D&R dashboard * Update collapse-side-nav-button.gif * Apply suggestions from code review Co-authored-by: benironside <[email protected]> Co-authored-by: nastasha-solomon <[email protected]> * Additional suggestions from code review Co-authored-by: benironside <[email protected]> * Update docs/getting-started/security-ui.asciidoc Co-authored-by: benironside <[email protected]> * Apply suggestions from code review * Update docs/dashboards/overview-dashboard.asciidoc * Apply suggestions from Janeen's review Co-authored-by: Janeen Mikell-Straughn <[email protected]> Co-authored-by: benironside <[email protected]> Co-authored-by: nastasha-solomon <[email protected]> Co-authored-by: Janeen Mikell-Straughn <[email protected]> (cherry picked from commit 0619d16) Co-authored-by: Joe Peeples <[email protected]>
Resolves #2040.
Involves a bit of re-architecting, since the Overview page is now grouped in a new major section "Dashboards," along with the new Detection & Response dashboard (with presumably more dashboards on the way).
Previews: