Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] New page: Detection & Response dashboard #2085

Merged
merged 11 commits into from
Jun 26, 2022

Conversation

joepeeples
Copy link
Contributor

@joepeeples joepeeples commented Jun 21, 2022

Resolves #2040.

Involves a bit of re-architecting, since the Overview page is now grouped in a new major section "Dashboards," along with the new Detection & Response dashboard (with presumably more dashboards on the way).

  • Creates new section: Dashboards
  • Moves Overview page to new topic within Dashboards
  • Creates new topic for D&R dashboard

Previews:

- Create new section: Dashboards
- Move Overview page to new topic within Dashboards
- Create new topic for D&R dashboard
@joepeeples joepeeples marked this pull request as ready for review June 21, 2022 18:51
Copy link
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor editorial suggestions for your consideration. Looks great overall and good idea to create new topics for the dashboards!

docs/dashboards/dashboards-overview.asciidoc Outdated Show resolved Hide resolved
docs/dashboards/detection-response-dashboard.asciidoc Outdated Show resolved Hide resolved
docs/dashboards/detection-response-dashboard.asciidoc Outdated Show resolved Hide resolved
docs/dashboards/detection-response-dashboard.asciidoc Outdated Show resolved Hide resolved
docs/dashboards/overview-dashboard.asciidoc Outdated Show resolved Hide resolved
docs/dashboards/detection-response-dashboard.asciidoc Outdated Show resolved Hide resolved
docs/dashboards/detection-response-dashboard.asciidoc Outdated Show resolved Hide resolved
docs/dashboards/detection-response-dashboard.asciidoc Outdated Show resolved Hide resolved
docs/dashboards/overview-dashboard.asciidoc Outdated Show resolved Hide resolved
docs/dashboards/overview-dashboard.asciidoc Outdated Show resolved Hide resolved
@jmikell821 jmikell821 requested a review from jamster10 June 22, 2022 21:04
@jmikell821
Copy link
Contributor

Hi @stephmilovic and @jamster10 - please review this PR when you have a moment - thanks!

@jmikell821 jmikell821 added the readyforQA PRs that are ready for QA review. label Jun 22, 2022
@jamster10
Copy link

jamster10 commented Jun 22, 2022

@jmikell821 , @joepeeples Thanks for writing this all up. It looks really good! :D. Going forward, Let me know if there are things I can do on my end to make your job easier- one thing for sure is as we build and expectation changes with design and product, Ill be sure to update the original ticket so the docs team knows of any changes.

Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an epic PR, absolute 🔥. I left kind of a lot of suggestions, I hope they are helpful.

docs/dashboards/dashboards-overview.asciidoc Outdated Show resolved Hide resolved
docs/dashboards/detection-response-dashboard.asciidoc Outdated Show resolved Hide resolved
docs/dashboards/detection-response-dashboard.asciidoc Outdated Show resolved Hide resolved
docs/dashboards/detection-response-dashboard.asciidoc Outdated Show resolved Hide resolved
docs/dashboards/detection-response-dashboard.asciidoc Outdated Show resolved Hide resolved
docs/dashboards/overview-dashboard.asciidoc Outdated Show resolved Hide resolved
docs/dashboards/overview-dashboard.asciidoc Outdated Show resolved Hide resolved
docs/getting-started/security-ui.asciidoc Outdated Show resolved Hide resolved
docs/getting-started/security-ui.asciidoc Outdated Show resolved Hide resolved
docs/getting-started/security-ui.asciidoc Outdated Show resolved Hide resolved
@ghost
Copy link

ghost commented Jun 23, 2022

Hi @nastasha-solomon

we have validated the preview page and all changes are correct and good to go ✔️

Fixed Areas:

  • Overview page

collapse-side-nav-button

  • Getting started page

image

  • Detection & Response dashboard

image

@ghost ghost added QA:Validated Issue has been Validated by QA Team and removed readyforQA PRs that are ready for QA review. labels Jun 23, 2022
@joepeeples joepeeples mentioned this pull request Jun 23, 2022
15 tasks
@joepeeples
Copy link
Contributor Author

joepeeples commented Jun 24, 2022

@jmikell821 , @joepeeples Thanks for writing this all up. It looks really good! :D. Going forward, Let me know if there are things I can do on my end to make your job easier- one thing for sure is as we build and expectation changes with design and product, Ill be sure to update the original ticket so the docs team knows of any changes.

Thanks @jamster10! Tagging us (@elastic/security-docs) on issues/epics/PRs is a great way to keep us in the loop, and please invite the team to any demos or similar design/dev events. There's a lot of exciting stuff happening with these dashboards, navigation, etc. and we love to get sneak peeks!

Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great feedback from the team! I only have a few slight suggestions. LGTM - thanks! 🎉

docs/dashboards/overview-dashboard.asciidoc Outdated Show resolved Hide resolved
docs/dashboards/overview-dashboard.asciidoc Outdated Show resolved Hide resolved
docs/dashboards/detection-response-dashboard.asciidoc Outdated Show resolved Hide resolved
docs/dashboards/detection-response-dashboard.asciidoc Outdated Show resolved Hide resolved
docs/dashboards/detection-response-dashboard.asciidoc Outdated Show resolved Hide resolved
@mergify
Copy link
Contributor

mergify bot commented Jun 26, 2022

This pull request is now in conflicts. Could you fix it @joepeeples? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b issue-2040-new-dashboard-detection-response upstream/issue-2040-new-dashboard-detection-response
git merge upstream/main
git push upstream issue-2040-new-dashboard-detection-response

@joepeeples joepeeples merged commit 0619d16 into main Jun 26, 2022
mergify bot pushed a commit that referenced this pull request Jun 26, 2022
* First draft

- Create new section: Dashboards
- Move Overview page to new topic within Dashboards
- Create new topic for D&R dashboard

* Update collapse-side-nav-button.gif

* Apply suggestions from code review

Co-authored-by: benironside <[email protected]>
Co-authored-by: nastasha-solomon <[email protected]>

* Additional suggestions from code review

Co-authored-by: benironside <[email protected]>

* Update docs/getting-started/security-ui.asciidoc

Co-authored-by: benironside <[email protected]>

* Apply suggestions from code review

* Update docs/dashboards/overview-dashboard.asciidoc

* Apply suggestions from Janeen's review

Co-authored-by: Janeen Mikell-Straughn <[email protected]>

Co-authored-by: benironside <[email protected]>
Co-authored-by: nastasha-solomon <[email protected]>
Co-authored-by: Janeen Mikell-Straughn <[email protected]>
(cherry picked from commit 0619d16)
joepeeples added a commit that referenced this pull request Jun 26, 2022
* First draft

- Create new section: Dashboards
- Move Overview page to new topic within Dashboards
- Create new topic for D&R dashboard

* Update collapse-side-nav-button.gif

* Apply suggestions from code review

Co-authored-by: benironside <[email protected]>
Co-authored-by: nastasha-solomon <[email protected]>

* Additional suggestions from code review

Co-authored-by: benironside <[email protected]>

* Update docs/getting-started/security-ui.asciidoc

Co-authored-by: benironside <[email protected]>

* Apply suggestions from code review

* Update docs/dashboards/overview-dashboard.asciidoc

* Apply suggestions from Janeen's review

Co-authored-by: Janeen Mikell-Straughn <[email protected]>

Co-authored-by: benironside <[email protected]>
Co-authored-by: nastasha-solomon <[email protected]>
Co-authored-by: Janeen Mikell-Straughn <[email protected]>
(cherry picked from commit 0619d16)

Co-authored-by: Joe Peeples <[email protected]>
@joepeeples joepeeples deleted the issue-2040-new-dashboard-detection-response branch June 26, 2022 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Dashboards QA:Validated Issue has been Validated by QA Team Team: Docs Team: Threat Hunting Formerly Data Visibility v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] New page: Detection & Response dashboard
6 participants