-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Add session ID to highlighted fields section in alert details flyout #2067
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Image looks good, I left a suggestion to improve the accuracy of the text.
Co-authored-by: benironside <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple small edits. Also super small issue, but the updated screenshot (alert-details-flyout.png
) has a lot of empty space toward the bottom that could be cropped out fairly easily.
Co-authored-by: Joe Peeples <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These look good to me -- I'm a +1 for Michael's suggestion. Adding the QA label for review tonight.
we have validated this preview links for the respected changes and all changes are available and good to go. Fixed Areas: Hence we are adding "QA:Validated" tag to it. thanks !! |
…flyout (#2067) Co-authored-by: benironside <[email protected]> Co-authored-by: Joe Peeples <[email protected]> (cherry picked from commit a895d07)
…tails flyout (backport #2067) (#2147) Co-authored-by: benironside <[email protected]> Co-authored-by: Joe Peeples <[email protected]> Co-authored-by: nastasha-solomon <[email protected]>
Fixes #2066.
Preview: