-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] OAuth authentication added to SN connectors #2048
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few comments and suggestions. A few comments speak to issues that were preexisting before this PR to add OAuth, so maybe a little out of scope and fine if you'd rather postpone re-architecting some of the tables.
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Left a few suggestions.
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Co-authored-by: benironside <91905639+benironside@users.noreply.github.com>
Co-authored-by: benironside <91905639+benironside@users.noreply.github.com>
we have validated this and found all the required changes present ✔️ Hence we are adding "QA:Valdiated" to it . thanks !!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SN changes LGTM
Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>
Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>
Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>
Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>
Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>
Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>
Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>
Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>
…s into issue-2042-oauth-sn
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too!
Co-authored-by: Joe Peeples <joe.peeples@elastic.co> Co-authored-by: benironside <91905639+benironside@users.noreply.github.com> Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com> (cherry picked from commit aeddc6b)
) (#2143) Co-authored-by: Joe Peeples <joe.peeples@elastic.co> Co-authored-by: benironside <91905639+benironside@users.noreply.github.com> Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com> Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>
Fixes #2042 and makes minor structural adjustments to steps that had bulleted sub-steps (changed bullets to table rows for a cleaner look).
Preview here.
NOTE: Main change was added docs for the Use OAuth authentication setting. At the moment, there's no way to link to the new sections that were added to the SN connector topics (anchors aren't there), so I linked to the main Connectors page instead. I can coordinate with @lcawl to add the anchors if needed.