Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] OAuth authentication added to SN connectors #2048

Merged
merged 40 commits into from
Jun 24, 2022

Conversation

nastasha-solomon
Copy link
Contributor

@nastasha-solomon nastasha-solomon commented Jun 7, 2022

Fixes #2042 and makes minor structural adjustments to steps that had bulleted sub-steps (changed bullets to table rows for a cleaner look).

Preview here.

NOTE: Main change was added docs for the Use OAuth authentication setting. At the moment, there's no way to link to the new sections that were added to the SN connector topics (anchors aren't there), so I linked to the main Connectors page instead. I can coordinate with @lcawl to add the anchors if needed.

@nastasha-solomon nastasha-solomon marked this pull request as ready for review June 13, 2022 18:04
@nastasha-solomon nastasha-solomon requested review from jmikell821, joepeeples, benironside, lcawl and cnasikas and removed request for cnasikas June 13, 2022 18:05
@nastasha-solomon nastasha-solomon mentioned this pull request Jun 13, 2022
15 tasks
Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments and suggestions. A few comments speak to issues that were preexisting before this PR to add OAuth, so maybe a little out of scope and fine if you'd rather postpone re-architecting some of the tables.

docs/cases/cases-ui-integrations.asciidoc Outdated Show resolved Hide resolved
docs/cases/cases-ui-integrations.asciidoc Outdated Show resolved Hide resolved
docs/cases/cases-ui-integrations.asciidoc Outdated Show resolved Hide resolved
docs/cases/cases-ui-integrations.asciidoc Outdated Show resolved Hide resolved
docs/cases/cases-ui-integrations.asciidoc Show resolved Hide resolved
docs/cases/cases-ui-integrations.asciidoc Show resolved Hide resolved
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left a few suggestions.

docs/cases/cases-ui-integrations.asciidoc Outdated Show resolved Hide resolved
docs/cases/cases-ui-integrations.asciidoc Outdated Show resolved Hide resolved
docs/cases/cases-ui-integrations.asciidoc Show resolved Hide resolved
nastasha-solomon and others added 4 commits June 16, 2022 14:42
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Co-authored-by: benironside <91905639+benironside@users.noreply.github.com>
Co-authored-by: benironside <91905639+benironside@users.noreply.github.com>
docs/cases/cases-ui-integrations.asciidoc Show resolved Hide resolved
docs/cases/cases-ui-integrations.asciidoc Outdated Show resolved Hide resolved
docs/cases/cases-ui-integrations.asciidoc Outdated Show resolved Hide resolved
docs/cases/cases-ui-integrations.asciidoc Show resolved Hide resolved
docs/cases/cases-ui-integrations.asciidoc Show resolved Hide resolved
@ghost
Copy link

ghost commented Jun 23, 2022

Hi @nastasha-solomon

we have validated this and found all the required changes present ✔️

image

image

Hence we are adding "QA:Valdiated" to it .

thanks !!!

@ghost ghost added QA:Validated Issue has been Validated by QA Team and removed readyforQA PRs that are ready for QA review. labels Jun 23, 2022
Copy link

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SN changes LGTM

nastasha-solomon and others added 16 commits June 23, 2022 15:56
Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>
Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>
Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>
Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>
Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>
Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>
Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>
Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>
Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too!

@nastasha-solomon nastasha-solomon merged commit aeddc6b into main Jun 24, 2022
@nastasha-solomon nastasha-solomon deleted the issue-2042-oauth-sn branch June 24, 2022 21:22
mergify bot pushed a commit that referenced this pull request Jun 24, 2022
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Co-authored-by: benironside <91905639+benironside@users.noreply.github.com>
Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>
(cherry picked from commit aeddc6b)
nastasha-solomon added a commit that referenced this pull request Jun 24, 2022
) (#2143)

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Co-authored-by: benironside <91905639+benironside@users.noreply.github.com>
Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>
Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] OAuth authentication added to SN ITSM, SecOps, and ITOM connectors
6 participants