Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Add note that binary fields are not supported in detection rule exceptions #1977

Merged
merged 8 commits into from
May 26, 2022

Conversation

joepeeples
Copy link
Contributor

@joepeeples joepeeples commented May 9, 2022

Resolves #1681.

Documented as a note within the exception docs (vs. a "known issue" in release notes) since this spans many versions. Also backporting to 8.0.0, but can go further back if necessary.

Preview: Rule exceptions and value lists

@joepeeples joepeeples marked this pull request as ready for review May 12, 2022 14:31
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks @joepeeples! 🙂

Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joepeeples
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/docs

Copy link

@jethr0null jethr0null left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joepeeples joepeeples merged commit f1788ba into main May 26, 2022
mergify bot pushed a commit that referenced this pull request May 26, 2022
mergify bot pushed a commit that referenced this pull request May 26, 2022
mergify bot pushed a commit that referenced this pull request May 26, 2022
mergify bot pushed a commit that referenced this pull request May 26, 2022
joepeeples added a commit that referenced this pull request May 26, 2022
(cherry picked from commit f1788ba)

Co-authored-by: Joe Peeples <[email protected]>
joepeeples added a commit that referenced this pull request May 26, 2022
(cherry picked from commit f1788ba)

Co-authored-by: Joe Peeples <[email protected]>
joepeeples added a commit that referenced this pull request May 26, 2022
(cherry picked from commit f1788ba)

Co-authored-by: Joe Peeples <[email protected]>
joepeeples added a commit that referenced this pull request May 26, 2022
(cherry picked from commit f1788ba)

Co-authored-by: Joe Peeples <[email protected]>
@joepeeples joepeeples deleted the issue-1681-binary-fields-rule-exceptions branch May 26, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] Add note that binary fields are not supported in Detection Rule Exceptions
6 participants