Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeline docs should be updated with the new UI. #4306

Closed
logeekal opened this issue Nov 21, 2023 · 9 comments · Fixed by #4483
Closed

Timeline docs should be updated with the new UI. #4306

logeekal opened this issue Nov 21, 2023 · 9 comments · Fixed by #4483
Assignees
Labels
Docset: ESS Issues that apply to docs in the Stack release Docset: Serverless Issues for Serverless Security Effort: Medium Issues that take moderate but not substantial time to complete Feature: Timeline Priority: Urgent Issues that need to be resolved as soon as possible Team: Threat Hunting Formerly Data Visibility v8.12.0

Comments

@logeekal
Copy link
Contributor

logeekal commented Nov 21, 2023

Description

Security solution is coming up with minor changes in the Timeline UI and all the changes have been covered in:

All the UI modifications are listed in the PR description. Please reach out to me if you some issue or you have some questions.

These Changes are coming in both Serverless and ESS in 8.12 release.

@joepeeples joepeeples added Team: Threat Hunting Formerly Data Visibility Docset: Serverless Issues for Serverless Security Docset: ESS Issues that apply to docs in the Stack release labels Nov 21, 2023
@nastasha-solomon nastasha-solomon self-assigned this Nov 27, 2023
@logeekal
Copy link
Contributor Author

@nastasha-solomon , updated the tour PR link.

@nastasha-solomon
Copy link
Contributor

nastasha-solomon commented Dec 2, 2023

The tour copy review is being tracked in #4369.

The issue linked in this issue's description (elastic/kibana#172030) tracks the implementation of the tour.

@nastasha-solomon
Copy link
Contributor

nastasha-solomon commented Dec 2, 2023

Serverless doc updates:

(Same updates were made to the ESS docs)

Updates to the Investigate events in Timeline page:

New or modified functionality that's not doc'd and needs to be added to the Investigate events in Timeline page:

timeline-design-updates
  • Favorites button - This button was accompanied by text (see image of 8.11 design above) in 8.11 and earlier. In 8.12, the favorite button is the starEmpty icon to the right of the Timeline title. By clicking the star, users can favorite or unfavorite a Timeline.
  • Create new and open existing Timeline buttons - These only existed on the main Timeline main page in 8.11, so they'll need to be doc'd for 8.12.
  • Collapse and expand query builder button - This is net new functionality.
    • Add a line about the default state of the query builder to the Narrow or expand your KQL query section. Also explain where to find the button because it's not labeled in the UI -- it's a button with the Timeline icon in the center. When users hover over the button, a tooltip with instructions of how to use the button appears.
  • Time range lock button - This button syncs (locks) or un-syncs (unlocks) the Timeline time range with/from the underlying page's time range.

Updates to the Create Timeline templates page:

Updates to the Data views in Elastic Security page:

Updates to the Timeline schema page:

  • Refresh -reference-timeline-object-ui.png - The top portion of the UI has completely changed, so I'll need to retake the image and re-apply the annotations (numbers) in the appropriate order so they align with the list following the image.
  • When revise above image, need to refresh list to show where updated objects are.
  • Remove the description reference in the following places:
    • The -reference-timeline-object-ui.png (number 2 sticker)
    • The numbered list following the screenshot

Updates to the Launch Timeline from investigation guides page:

@nastasha-solomon nastasha-solomon added Priority: Urgent Issues that need to be resolved as soon as possible Effort: Medium Issues that take moderate but not substantial time to complete labels Dec 2, 2023
@logeekal
Copy link
Contributor Author

logeekal commented Dec 4, 2023

This heading states Narrow or expand your KQL query but it talks about query filters. Should we rename it to just query instead of KQL Query?


Favorites button - This button was accompanied by text (see image of 8.11 design above) in 8.11 and earlier. In 8.12, the favorite button is the starEmpty icon to the right of the Timeline title. By clicking the star, users can favorite or unfavorite a Timeline.

There is still some discussion here. I have meeting with design tomorrow, I will confirm you about the direction we are going for this.


Probably you have already noted it. But https://docs.elastic.co/serverless/security/timeline-object-schema also needs updated screenshot. I am putting it here since it is not mentioned in your comment.

@nastasha-solomon
Copy link
Contributor

Thanks for the additional notes, @logeekal! I expanded the list of doc updates to include the updates needed to the Timeline schema page and will check in with you tomorrow on design decisions made about the favorites button and expand/collapse query builder button.

RE your question about the section title:

This heading states Narrow or expand your KQL query but it talks about query filters. Should we rename it to just query instead of KQL Query?

Does the query builder use KQL or is it using a different query language? I always thought it was a visual representation of the text-based KQL query bar above it, but maybe I'm wrong?

@logeekal
Copy link
Contributor Author

logeekal commented Dec 7, 2023

Hey @nastasha-solomon ,

Below are my responses.

Filter Timeline results with EQL

Refresh -events-correlation-tab-eql-query.png

Below is the replacement screenshot :

image

Does the query builder use KQL or is it using a different query language? I always thought it was a visual representation of the text-based KQL query bar above it, but maybe I'm wrong?

I would say, it is a subset of KQL but not exactly KQL. It cannot do NOT ( ... complete query ) which can be done in KQL. I will ask team today for confirmation and get back to you.

@nastasha-solomon
Copy link
Contributor

elastic/kibana#173015 introduces some additional UI changes that'll impact screenshots and potentially instructions for opening an existing Timeline, creating a new Timeline, and creating a new Timeline template.

I plan to lump the newest UI changes into https://github.com/elastic/staging-serverless-security-docs/pull/240 so I can consolidate everything into a single docs PR.

@logeekal
Copy link
Contributor Author

logeekal commented Dec 13, 2023

@nastasha-solomon , I have updated the EQL screenshot in above comment with the new changes. So you can take from there directly.

@nastasha-solomon
Copy link
Contributor

Noticed a handful of additional screenshots that need to be refreshed. Adding them to the list and committing them to the ESS and Serverless doc PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docset: ESS Issues that apply to docs in the Stack release Docset: Serverless Issues for Serverless Security Effort: Medium Issues that take moderate but not substantial time to complete Feature: Timeline Priority: Urgent Issues that need to be resolved as soon as possible Team: Threat Hunting Formerly Data Visibility v8.12.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants