Honor runtime JDK in provisioner #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently rely on `java` being available on the PATH when provisioning an Elasticsearch node but instead we should be consistent and always use the specified runtime JDK when provisoning a node. With this commit we determine the correct runtime JDK and set it as `JAVA_HOME` when provisioning a node.
danielmitterdorfer
added
bug
|
Note that this change is backwards-compatible and can be merged independently of elastic/rally-teams#24. |
|
Steps to reproduce the problem: |
danielmitterdorfer
changed the title
danielmitterdorfer
added a commit
to elastic/rally-teams
that referenced
this pull request
Apr 3, 2019
So far we implicitly rely on `java` being available on the path. However, we should rather use the runtime JDK for post-install hooks similarly to the runtime JDK that we use when invoking Elasticsearch itself. Relates elastic/rally#673 Relates #24
danielmitterdorfer
added a commit
to elastic/rally-teams
that referenced
this pull request
Apr 3, 2019
So far we implicitly rely on `java` being available on the path. However, we should rather use the runtime JDK for post-install hooks similarly to the runtime JDK that we use when invoking Elasticsearch itself. Relates elastic/rally#673 Relates #24
danielmitterdorfer
added a commit
to elastic/rally-teams
that referenced
this pull request
Apr 3, 2019
So far we implicitly rely on `java` being available on the path. However, we should rather use the runtime JDK for post-install hooks similarly to the runtime JDK that we use when invoking Elasticsearch itself. Relates elastic/rally#673 Relates #24
|
Thanks for the review! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently rely on
javabeing available on the PATH whenprovisioning an Elasticsearch node but instead we should be consistent
and always use the specified runtime JDK when provisoning a node. With
this commit we determine the correct runtime JDK and set it as
JAVA_HOMEwhen provisioning a node.Relates elastic/rally-teams#24