Remove Elasticsearch 6.3 logic #1497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rally only supports Elasticsearch 6.8+.
pquentin
added
cleanup
pquentin
commented
Jul 4, 2022
| @@ -354,8 +354,7 @@ def _after_track_prepared(self): | |||
| self.send( | |||
| self.start_sender, | |||
| PreparationComplete( | |||
| # older versions (pre 6.3.0) don't expose build_flavor because the only (implicit) flavor was "oss" | |||
| cluster_version.get("build_flavor", "oss"), | |||
There was a problem hiding this comment.
This breaks the ClusterEnvironmentInfo telemetry device when no build flavor is set, eg. esrally race --revision=latest --track=geonames --test-mode --car=4gheap,basic-license breaks.
|
Please take another look! |
pquentin
added
:misc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rally only supports Elasticsearch 6.8+.