Improve the wikipedia track. #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afoucret
commented
Sep 21, 2023
| }, | ||
| } | ||
| } | ||
| except StopIteration: |
There was a problem hiding this comment.
Non-blocking question: Do we see any exception for this part? Does this happen due to long running of the benchmark?
| @@ -40,14 +40,12 @@ | |||
| { | |||
| "name": "default-search-application-search", | |||
| "operation-type": "raw-request", | |||
| "param-source": "search-application-search-param-source", | |||
| "iterations": {{search_iterations | default(100000)}} | |||
There was a problem hiding this comment.
Non-blocking question: Can you please explain why we remove the iterations attribute?
saikatsarkar056
approved these changes
Sep 27, 2023
|
The change looks good to me. I have some non-blocking questions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the way search are executed. We are now using a time period of 5 minutes instead of a fixed number of execution.
This allows to get more reliable results.