Benchmark for date_histo with one bucket #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a benchmark for `date_histogram` when a single bucket covers the entire index. We expect this to be quite common for buckets with a size near a day. Its fairly common for folks to use "daily" indices that contain *about* a day's worth of data. That day isn't likely to line up *exactly* with daily buckets. But for buckets marginally larger than a day and for indices even a little smaller than a day I think it'll be quite common.
|
@nik9000 will merge this on Monday (typically we won't merge track changes on Fri to prevent chances of broken nightlies during the weekend). Question: how far back should this be backported? |
|
Thanks! |
|
@nik9000 regarding backporting, how far back can this go? |
|
It can run as far back as you'd like. I likey won't run it on old branches
though. The code should work on most versions of es after .say, 1.0.
…On Mon, Apr 5, 2021, 03:27 Dimitrios Liappis ***@***.***> wrote:
@nik9000 <https://github.com/nik9000> regarding backporting, how far back
can this go?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#165 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABUXIWOTWCJ2OKKQMVQDCLTHFQ75ANCNFSM42HBW6QQ>
.
|
Do you mean after |
I mean its safe to backport it as far as you like. But 7.12 is certainly far enough for me. 7.13 even. |
dliappis
pushed a commit
that referenced
this pull request
Apr 5, 2021
This adds a benchmark for `date_histogram` when a single bucket covers the entire index. We expect this to be quite common for buckets with a size near a day. Its fairly common for folks to use "daily" indices that contain *about* a day's worth of data. That day isn't likely to line up *exactly* with daily buckets. But for buckets marginally larger than a day and for indices even a little smaller than a day I think it'll be quite common.
Backported to 7.12 using 11cee00 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a benchmark for
date_histogramwhen a single bucket coversthe entire index. We expect this to be quite common for buckets with a
size near a day. Its fairly common for folks to use "daily" indices that
contain about a day's worth of data. That day isn't likely to line up
exactly with daily buckets. But for buckets marginally larger than a
day and for indices even a little smaller than a day I think it'll be
quite common.
Benchmark for elastic/elasticsearch#71180