-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flag to indicate if a bundled JDK is available #37
Merged
danielmitterdorfer
merged 1 commit into
elastic:master
from
danielmitterdorfer:indicate-bundled-jdk
Jan 7, 2020
Merged
Add flag to indicate if a bundled JDK is available #37
danielmitterdorfer
merged 1 commit into
elastic:master
from
danielmitterdorfer:indicate-bundled-jdk
Jan 7, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we add a new variable that indicates whether a distribution contains a bundled JDK. This can be used in the future by Rally for various decisions whether it requires a user-provided JDK on the system.
dliappis
approved these changes
Jan 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
danielmitterdorfer
added a commit
that referenced
this pull request
Jan 7, 2020
With this commit we add a new variable that indicates whether a distribution contains a bundled JDK. This can be used in the future by Rally for various decisions whether it requires a user-provided JDK on the system.
danielmitterdorfer
added a commit
that referenced
this pull request
Jan 7, 2020
With this commit we add a new variable that indicates whether a distribution contains a bundled JDK. This can be used in the future by Rally for various decisions whether it requires a user-provided JDK on the system.
danielmitterdorfer
added a commit
that referenced
this pull request
Jan 7, 2020
With this commit we add a new variable that indicates whether a distribution contains a bundled JDK. This can be used in the future by Rally for various decisions whether it requires a user-provided JDK on the system.
danielmitterdorfer
added a commit
that referenced
this pull request
Jan 7, 2020
With this commit we add a new variable that indicates whether a distribution contains a bundled JDK. This can be used in the future by Rally for various decisions whether it requires a user-provided JDK on the system.
danielmitterdorfer
added a commit
that referenced
this pull request
Jan 7, 2020
With this commit we add a new variable that indicates whether a distribution contains a bundled JDK. This can be used in the future by Rally for various decisions whether it requires a user-provided JDK on the system.
danielmitterdorfer
added a commit
that referenced
this pull request
Jan 7, 2020
With this commit we add a new variable that indicates whether a distribution contains a bundled JDK. This can be used in the future by Rally for various decisions whether it requires a user-provided JDK on the system.
danielmitterdorfer
added a commit
that referenced
this pull request
Jan 7, 2020
With this commit we add a new variable that indicates whether a distribution contains a bundled JDK. This can be used in the future by Rally for various decisions whether it requires a user-provided JDK on the system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we add a new variable that indicates whether a
distribution contains a bundled JDK. This can be used in the future by
Rally for various decisions whether it requires a user-provided JDK on
the system.