Parameterize OS name + CPU arch in download URL. #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmitterdorfer
approved these changes
Oct 1, 2019
There was a problem hiding this comment.
Thanks for raising the PR. The change looks fine to me. However, I have a couple of notes:
- We should hold back from merging this at least until Rally 1.5.0 is out. This is a breaking change that will only work with Rally 1.4.0 or better and we should give users some time to upgrade.
- We also need to forward-port this to the
masterbranch. Usually I create PRs againstmasterand backport the change as far as needed but personally I'm ok if we keep this PR as is and forward port it.
|
@drawlerr I just noticed that we should also customize the vanilla config: Can you please change it there as well? |
danielmitterdorfer
added a commit
that referenced
this pull request
Oct 2, 2019
This reverts commit 760907f.
danielmitterdorfer
added
the
blocked
danielmitterdorfer
removed
the
blocked
|
superseded by #38 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should use the new template parameters to get the correct version of ES for our platform + arch.