Allow telemetry devices use jvm.options instead of ES_JAVA_OPTS #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unblocks elastic/rally#711 |
danielmitterdorfer
approved these changes
Jun 14, 2019
| @@ -112,3 +112,10 @@ | |||
| # due to internationalization enhancements in JDK 9 Elasticsearch need to set the provider to COMPAT otherwise | |||
| # time/date parsing will break in an incompatible way for some date patterns and locals | |||
| 9-:-Djava.locale.providers=COMPAT | |||
|
|
|||
| {# cluster settings provided by the user via the command line #} | |||
There was a problem hiding this comment.
Nit: The comment is not applicable here. I'd probably just get rid of it.
|
We should backport this as far as |
|
@danielmitterdorfer Thank you for the review! |
ebadyano
added a commit
that referenced
this pull request
Jun 18, 2019
ebadyano
added a commit
that referenced
this pull request
Jun 18, 2019
danielmitterdorfer
pushed a commit
that referenced
this pull request
Aug 13, 2019
danielmitterdorfer
pushed a commit
that referenced
this pull request
Aug 13, 2019
danielmitterdorfer
pushed a commit
that referenced
this pull request
Aug 13, 2019
danielmitterdorfer
pushed a commit
that referenced
this pull request
Aug 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.