Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile and run Elasticsearch with JDK 12 #22

Merged
merged 1 commit into from
Mar 20, 2019

Conversation

danielmitterdorfer
Copy link
Member

With this commit we set the required JDK for compiling Elasticsearch to
JDK 12 and also allow to run it with JDK 12.

With this commit we set the required JDK for compiling Elasticsearch to
JDK 12 and also allow to run it with JDK 12.
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks. I guess it makes sense to first create a 7 branch and push and then merge this?

@danielmitterdorfer
Copy link
Member Author

No, there is no need for a new branch because also Elasticsearch 7.0 will require JDK 12 for compilation (see elastic/elasticsearch#40231).

@dliappis
Copy link
Contributor

Ok thanks for clarifying then let's merge.

@danielmitterdorfer danielmitterdorfer merged commit 98baa15 into elastic:master Mar 20, 2019
@danielmitterdorfer danielmitterdorfer deleted the jdk-12 branch March 20, 2019 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants